Fix next compat to convey state for classic.

Fix next compat to convey state for classic.

ChromeVox's content script requests a boolean isClasicEnabled before document load (sometimes). Ensure that boolean accounts for the next compat reg exp.
BUG=657098, 657100, 657092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1f44b4e2c4b84f0111028ef02b4006f1d8afb079
Cr-Commit-Position: refs/heads/master@{#427420}

[David Tseng, 2016-10-24 16:15:42]

Description was changed from

==========
Fix next compat to convey state for classic.

ChromeVox's content script requests a boolean isClasicEnabled before document
load (sometimes). Ensure that boolean accounts for the next compat reg exp.

Fix editable text selection

We need to special-case setting selections when the focused node is itself
editable.
- make no adjustments for the selected node; placing selection outside of the
editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0
(placing selection at the beginning of the node); otherwise, use the character
offset

BUG=
==========

to

==========
Fix next compat to convey state for classic.

ChromeVox's content script requests a boolean isClasicEnabled before document
load (sometimes). Ensure that boolean accounts for the next compat reg exp.

Fix editable text selection

We need to special-case setting selections when the focused node is itself
editable.
- make no adjustments for the selected node; placing selection outside of the
editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0
(placing selection at the beginning of the node); otherwise, use the character
offset

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-24 16:17:32]

Description was changed from

==========
Fix next compat to convey state for classic.

ChromeVox's content script requests a boolean isClasicEnabled before document
load (sometimes). Ensure that boolean accounts for the next compat reg exp.

Fix editable text selection

We need to special-case setting selections when the focused node is itself
editable.
- make no adjustments for the selected node; placing selection outside of the
editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0
(placing selection at the beginning of the node); otherwise, use the character
offset

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix next compat to convey state for classic.

ChromeVox's content script requests a boolean isClasicEnabled before document
load (sometimes). Ensure that boolean accounts for the next compat reg exp.
BUG=657098,657100,657092
==========

[David Tseng, 2016-10-24 16:17:33]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-10-24 16:28:57]

The change description doesn't match the diff, do you need a rebase?

https://codereview.chromium.org/2443273002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js
(right):

https://codereview.chromium.org/2443273002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js:169: //
Make no adjustments if we're within editable content.
This is from a different change?

[David Tseng, 2016-10-24 19:09:26]

Description was changed from

==========
Fix next compat to convey state for classic.

ChromeVox's content script requests a boolean isClasicEnabled before document
load (sometimes). Ensure that boolean accounts for the next compat reg exp.
BUG=657098,657100,657092
==========

to

==========
Fix next compat to convey state for classic.

ChromeVox's content script requests a boolean isClasicEnabled before document
load (sometimes). Ensure that boolean accounts for the next compat reg exp.
BUG=657098,657100,657092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-24 19:10:52]

https://codereview.chromium.org/2443273002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js
(right):

https://codereview.chromium.org/2443273002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js:169: //
Make no adjustments if we're within editable content.
On 2016/10/24 16:28:57, dmazzoni wrote:
> This is from a different change?

Sorry; yup; re-uploaded.

[dmazzoni, 2016-10-25 17:00:41]

lgtm

[David Tseng, 2016-10-25 17:32:13]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-10-25 17:33:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 18:35:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 19:09:02]

Description was changed from

==========
Fix next compat to convey state for classic.

ChromeVox's content script requests a boolean isClasicEnabled before document
load (sometimes). Ensure that boolean accounts for the next compat reg exp.
BUG=657098,657100,657092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix next compat to convey state for classic.

ChromeVox's content script requests a boolean isClasicEnabled before document
load (sometimes). Ensure that boolean accounts for the next compat reg exp.
BUG=657098,657100,657092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1f44b4e2c4b84f0111028ef02b4006f1d8afb079
Cr-Commit-Position: refs/heads/master@{#427420}
==========

[commit-bot: I haz the power, 2016-10-25 19:09:03]

Patchset 2 (id:??) landed as
https://crrev.com/1f44b4e2c4b84f0111028ef02b4006f1d8afb079
Cr-Commit-Position: refs/heads/master@{#427420}