Move to using HTML templates when filling out the workspace history.

Move to using HTML templates when filling out the workspace history.

This is a pre-step to having a history list that you can click on
and having the code moved back into the textarea, which will come
as a follow-up CL.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14283

[mtklein, 2014-04-21 16:19:01]

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/css/...
File experimental/webtry/css/webtry.css (right):

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/css/...
experimental/webtry/css/webtry.css:35: display: none;
Just out of curiosity, is this here only for the polyfill case?  I'd think
<template> normally wasn't displayed?

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/js/r...
File experimental/webtry/js/run.js (right):

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/js/r...
experimental/webtry/js/run.js:20: while (templates[i].firstChild) {
This may be me being rusty on the DOM, but is this not an infinite loop?

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/webt...
File experimental/webtry/webtry.go (right):

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/webt...
experimental/webtry/webtry.go:440: code = getCode(tries[len(tries)-1].Hash)
Undo?

[jcgregorio, 2014-04-21 16:26:23]

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/css/...
File experimental/webtry/css/webtry.css (right):

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/css/...
experimental/webtry/css/webtry.css:35: display: none;
Yes, only needed for the polyfill.

On 2014/04/21 16:19:01, mtklein wrote:
> Just out of curiosity, is this here only for the polyfill case?  I'd think
> <template> normally wasn't displayed?

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/js/r...
File experimental/webtry/js/run.js (right):

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/js/r...
experimental/webtry/js/run.js:20: while (templates[i].firstChild) {
A node can only be owned by one parent, when the node is appended to content it
is automatically removed from templates[i].


On 2014/04/21 16:19:01, mtklein wrote:
> This may be me being rusty on the DOM, but is this not an infinite loop?

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/webt...
File experimental/webtry/webtry.go (right):

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/webt...
experimental/webtry/webtry.go:440: code = getCode(tries[len(tries)-1].Hash)
This was intentional, the history list is constructed in JS and it works by
appending to the head of history, so the DESC had to be removed from the SELECT
query above, which means the most recent try is now the last try again.

On 2014/04/21 16:19:01, mtklein wrote:
> Undo?

[mtklein, 2014-04-21 16:31:14]

lgtm

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/js/r...
File experimental/webtry/js/run.js (right):

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/js/r...
experimental/webtry/js/run.js:20: while (templates[i].firstChild) {
On 2014/04/21 16:26:24, jcgregorio wrote:
> A node can only be owned by one parent, when the node is appended to content
it
> is automatically removed from templates[i].
> 
> 
> On 2014/04/21 16:19:01, mtklein wrote:
> > This may be me being rusty on the DOM, but is this not an infinite loop?
> 
Ah, duh, clearly rusty.

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/webt...
File experimental/webtry/webtry.go (right):

https://codereview.chromium.org/244313007/diff/70001/experimental/webtry/webt...
experimental/webtry/webtry.go:440: code = getCode(tries[len(tries)-1].Hash)
On 2014/04/21 16:26:24, jcgregorio wrote:
> This was intentional, the history list is constructed in JS and it works by
> appending to the head of history, so the DESC had to be removed from the
SELECT
> query above, which means the most recent try is now the last try again.
> 
> On 2014/04/21 16:19:01, mtklein wrote:
> > Undo?
> 
Ah!  Missed the DESC change.  Thanks.

[jcgregorio, 2014-04-21 16:32:38]

The CQ bit was checked by jcgregorio@google.com

[commit-bot: I haz the power, 2014-04-21 16:32:42]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/244313007/70001

[commit-bot: I haz the power, 2014-04-21 17:36:47]

Change committed as 14283