Delete ShallowCopy, in favor of copy construction and assignment.

webrtc/common_video/video_frame.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 75 matching lines @@
   const int stride_y = width;
   const int stride_uv = (width + 1) / 2;
 
   const uint8_t* buffer_y = buffer;
   const uint8_t* buffer_u = buffer_y + stride_y * height;
   const uint8_t* buffer_v = buffer_u + stride_uv * ((height + 1) / 2);
   CreateFrame(buffer_y, buffer_u, buffer_v, width, height, stride_y,
               stride_uv, stride_uv, rotation);
 }
 
 void VideoFrame::ShallowCopy(const VideoFrame& videoFrame) {

[tommi, 2016/10/24 10:52:17]

change variable name to video_frame? (or even just frame)

[nisse-chromium (ooo August 14), 2016/10/24 11:01:20]

Done.

-  video_frame_buffer_ = videoFrame.video_frame_buffer();
-  timestamp_rtp_ = videoFrame.timestamp_rtp_;
-  ntp_time_ms_ = videoFrame.ntp_time_ms_;
-  timestamp_us_ = videoFrame.timestamp_us_;
-  rotation_ = videoFrame.rotation_;
+  *this = videoFrame;
 }
 
 int VideoFrame::width() const {
   return video_frame_buffer_ ? video_frame_buffer_->width() : 0;
 }
 
 int VideoFrame::height() const {
   return video_frame_buffer_ ? video_frame_buffer_->height() : 0;
 }
 
@@ skipping 18 matching lines @@
     case kVideoCodecULPFEC:
     case kVideoCodecGeneric:
     case kVideoCodecUnknown:
       return 0;
   }
   RTC_NOTREACHED();
   return 0;
 }
 
 }  // namespace webrtc