Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2443113003: Make .pyc cleaning optional in clean_local_files. (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, ehmaldonado_chromium
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Make .pyc cleaning optional in clean_local_files. In the chromium_android recipe module, the clean_local_files step sometimes take 5-10 minutes to execute. BUG=658722 Committed: https://chromium.googlesource.com/chromium/tools/build/+/fa4ef27d0c0c5260e61dacb1a416760aec93757a

Patch Set 1 #

Patch Set 2 : Fixed expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -191 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 2 chunks +21 lines, -15 lines 0 comments Download
M scripts/slave/recipe_modules/webrtc/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__dbg_.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_mips__dbg_.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_x86.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_x86__dbg_.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_clang__dbg_.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_gyp.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_gyp__dbg_.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_builder_x64__dbg_.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_builder.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_release__swarming_.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__j_nexus4_.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__k_nexus5_.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__l_nexus6_.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder_forced.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced_invalid.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_clang_dbg.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_dbg.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_rel.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_dbg.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_mips_dbg.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_rel.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x64_dbg.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x86_dbg.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x86_rel.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_gyp_dbg.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_gyp_rel.json View 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
kjellander_chromium
4 years, 1 month ago (2016-10-24 14:07:21 UTC) #2
kjellander_chromium
Pawel, can you have a look since stip@ seems busy?
4 years, 1 month ago (2016-10-26 08:41:42 UTC) #12
Paweł Hajdan Jr.
LGTM
4 years, 1 month ago (2016-10-26 09:31:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443113003/20001
4 years, 1 month ago (2016-10-26 09:47:43 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 09:57:07 UTC) #17
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/fa4ef27d0c0c5260e61d...

Powered by Google App Engine
This is Rietveld 408576698