Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: media/midi/midi_manager.h

Issue 2443113002: Fix possible multiple calls to MidiManager::StartInitialization() in StartSession() (Closed)
Patch Set: styles Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/midi/midi_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_manager.h
diff --git a/media/midi/midi_manager.h b/media/midi/midi_manager.h
index 9d0896a3703bd833ab46509ce4e108e61867d27b..f90a55b6443df5cc17a68563260b7f959db538c2 100644
--- a/media/midi/midi_manager.h
+++ b/media/midi/midi_manager.h
@@ -175,6 +175,12 @@ class MIDI_EXPORT MidiManager {
const MidiPortInfoList& output_ports() const { return output_ports_; }
private:
+ enum class InitializationState {
+ NOT_STARTED,
+ STARTED,
+ COMPLETED,
+ };
+
void CompleteInitializationInternal(mojom::Result result);
void AddInitialPorts(MidiManagerClient* client);
void ShutdownOnSessionThread();
@@ -190,8 +196,8 @@ class MIDI_EXPORT MidiManager {
// order to invoke CompleteStartSession() on the thread.
scoped_refptr<base::SingleThreadTaskRunner> session_thread_runner_;
- // Keeps true if platform dependent initialization is already completed.
- bool initialized_;
+ // Tracks platform dependent initialization state.
+ InitializationState initialization_state_;
// Keeps false until Finalize() is called.
bool finalized_;
@@ -205,7 +211,7 @@ class MIDI_EXPORT MidiManager {
MidiPortInfoList output_ports_;
// Protects access to |clients_|, |pending_clients_|,
- // |session_thread_runner_|, |initialized_|, |finalize_|, |result_|,
+ // |session_thread_runner_|, |initialization_state_|, |finalize_|, |result_|,
// |input_ports_| and |output_ports_|.
base::Lock lock_;
« no previous file with comments | « no previous file | media/midi/midi_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698