Defer creating ChromeVox node menus to make menus open more quickly.

chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview The ChromeVox panel and menus.
  */
 
 goog.provide('Panel');
 
@@ skipping 337 matching lines @@
       }
     });
   });
 
   // Add a menu item that disables / closes ChromeVox.
   chromevoxMenu.addMenuItem(
       Msgs.getMsg('disable_chromevox'), 'Ctrl+Alt+Z', function() {
         Panel.onClose();
       });
 
-  // Add menus for various role types.
+  var roleListMenuMapping = [
+    { menuTitle: 'role_heading', predicate: AutomationPredicate.heading },
+    { menuTitle: 'role_landmark', predicate: AutomationPredicate.landmark },
+    { menuTitle: 'role_link', predicate: AutomationPredicate.link },
+    { menuTitle: 'role_form', predicate: AutomationPredicate.formField },
+    { menuTitle: 'role_table', predicate: AutomationPredicate.table }];
+
   var node = bkgnd.ChromeVoxState.instance.getCurrentRange().start.node;
-  Panel.addNodeMenu('role_heading', node, AutomationPredicate.heading);
-  Panel.addNodeMenu('role_landmark', node, AutomationPredicate.landmark);
-  Panel.addNodeMenu('role_link', node, AutomationPredicate.link);
-  Panel.addNodeMenu('role_form', node, AutomationPredicate.formField);
-  Panel.addNodeMenu('role_table', node, AutomationPredicate.table);
+  for (var i = 0; i < roleListMenuMapping.length; ++i) {
+    var menuTitle = roleListMenuMapping[i].menuTitle;
+    var predicate = roleListMenuMapping[i].predicate;
+    // Create node menus asynchronously (because it may require searching a
+    // long document) unless that's the specific menu the
+    // user requested.
+    var async = (menuTitle != opt_activateMenuTitle);
+    Panel.addNodeMenu(menuTitle, node, predicate, async);
+  }
 
   // Activate either the specified menu or the first menu.
   var selectedMenu = Panel.menus_[0];
   for (var i = 0; i < Panel.menus_.length; i++) {
     if (this.menus_[i].menuMsg == opt_activateMenuTitle)
       selectedMenu = this.menus_[i];
   }
   Panel.activateMenu(selectedMenu);
 };
 
@@ skipping 36 matching lines @@
 
   $('menus_background').appendChild(menu.menuContainerElement);
   this.menus_.push(menu);
   return menu;
 };
 
 
 /**
  * Create a new node menu with the given name and add it to the menu bar.
  * @param {string} menuMsg The msg id of the new menu to add.
- * @param {chrome.automation.AutomationNode} node
+ * @param {!chrome.automation.AutomationNode} node
  * @param {AutomationPredicate.Unary} pred
+ * @param {boolean} defer If true, defers populating the menu.
  * @return {PanelMenu} The menu just created.
  */
-Panel.addNodeMenu = function(menuMsg, node, pred) {
-  var menu = new PanelNodeMenu(menuMsg, node, pred);
+Panel.addNodeMenu = function(menuMsg, node, pred, defer) {
+  var menu = new PanelNodeMenu(menuMsg, node, pred, defer);
   $('menu-bar').appendChild(menu.menuBarItemElement);
   menu.menuBarItemElement.addEventListener('mouseover', function() {
     Panel.activateMenu(menu);
   }, false);
 
   $('menus_background').appendChild(menu.menuContainerElement);
   this.menus_.push(menu);
   return menu;
 };
 
@@ skipping 264 matching lines @@
 }, false);
 
 window.addEventListener('hashchange', function() {
   if (location.hash == '#fullscreen' || location.hash == '#focus') {
     this.originalStickyState_ = cvox.ChromeVox.isStickyPrefOn;
     cvox.ChromeVox.isStickyPrefOn = false;
   } else {
     cvox.ChromeVox.isStickyPrefOn = this.originalStickyState_;
   }
 }, false);