Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2443093002: memory coordinator: Observe renderer visibility to update state (Closed)

Created:
4 years, 2 months ago by bashi
Modified:
4 years, 1 month ago
Reviewers:
haraken, chrisha
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

memory coordinator: Observe renderer visibility to update state Memory coordinator should update renderers' memory state when their visibility have changed. For a visible (foreground) renderer, the state is set to NORMAL. For background renderers, the states are set to the global state. BUG=617492 Committed: https://crrev.com/efbf745f1739de118eb193f24e8e9ed9a6f7cc9f Cr-Commit-Position: refs/heads/master@{#427185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M content/browser/memory/memory_coordinator_impl.h View 4 chunks +9 lines, -0 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.cc View 4 chunks +26 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
bashi
PTAL It's a bit difficult to add a test because we don't expose MemoryCoordinator to ...
4 years, 2 months ago (2016-10-24 07:53:30 UTC) #4
haraken
LGTM
4 years, 2 months ago (2016-10-24 08:42:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443093002/1
4 years, 1 month ago (2016-10-25 00:03:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 00:11:32 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 00:17:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efbf745f1739de118eb193f24e8e9ed9a6f7cc9f
Cr-Commit-Position: refs/heads/master@{#427185}

Powered by Google App Engine
This is Rietveld 408576698