Delay invalidating linked hashes until after checking the API signature of the changed file.

Delay invalidating linked hashes until after checking the API signature of the changed file.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/a42e0e94d8b1030270c0ae6f97c4fae502acb06c

[Paul Berry, 2016-10-24 12:12:04]

https://codereview.chromium.org/2443083002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2443083002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:595: PackageBundle
_getUnlinked(_File file, {bool computeIfNotCached: true}) {
I'm not a huge fan of the new boolean.  Really all we need is to extract the
logic for getting the data from the cache into its own function, like so:

PackageBundle _getCachedUnlinked(_File file) {
  // Get from the cache; if not present return null.
}
PackageBundle _getUnlinked(_File file) {
  return _getCachedUnlinked(file) ?? _logger.runTimed(...);
}

https://codereview.chromium.org/2443083002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:643:
_filesToVerifyUnlinkedSignature.clear();
This line should be moved after the "for" loop.  (If all signatures match, we
still want to clear _filesToVerifyUnlinkedSignature, so that we don't waste time
verifying extra files next time).

[scheglov, 2016-10-24 19:15:58]

https://codereview.chromium.org/2443083002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2443083002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:595: PackageBundle
_getUnlinked(_File file, {bool computeIfNotCached: true}) {
On 2016/10/24 12:12:04, Paul Berry wrote:
> I'm not a huge fan of the new boolean.  Really all we need is to extract the
> logic for getting the data from the cache into its own function, like so:
> 
> PackageBundle _getCachedUnlinked(_File file) {
>   // Get from the cache; if not present return null.
> }
> PackageBundle _getUnlinked(_File file) {
>   return _getCachedUnlinked(file) ?? _logger.runTimed(...);
> }

Thank you.
It is much cleaner the way you proposed.

https://codereview.chromium.org/2443083002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:643:
_filesToVerifyUnlinkedSignature.clear();
On 2016/10/24 12:12:04, Paul Berry wrote:
> This line should be moved after the "for" loop.  (If all signatures match, we
> still want to clear _filesToVerifyUnlinkedSignature, so that we don't waste
time
> verifying extra files next time).

Done.

[scheglov, 2016-10-24 19:16:12]

Description was changed from

==========
Delay invalidating linked hashes until after checking the API signature of the
changed file.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Delay invalidating linked hashes until after checking the API signature of the
changed file.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/a42e0e94d8b1030270c0ae6f97c4fae502acb06c
==========

[scheglov, 2016-10-24 19:16:13]

Committed patchset #2 (id:20001) manually as
a42e0e94d8b1030270c0ae6f97c4fae502acb06c (presubmit successful).

[Brian Wilkerson, 2016-10-26 06:38:12]

lgtm

[Paul Berry, 2016-10-31 15:28:13]

lgtm