Mark several w3c tests for service workers [ Slow ]

Mark several w3c tests for service workers [ Slow ]

Several web platform tests introduced at https://crrev.com/2441963002 are passed
with longer timeout. This patch is to keep the bots green.

BUG=602693, 658997
Committed: https://crrev.com/74e0e4302ff524635ecbef0e45cecbda268e8552
Cr-Commit-Position: refs/heads/master@{#427600}

[shimazu, 2016-10-24 04:14:52]

shimazu@chromium.org changed reviewers:
+ falken@chromium.org

[shimazu, 2016-10-24 04:14:53]

ptal:)

FYI: failing bots are here
- Win:
https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Win%20-%20WPTServ...
- Mac:
https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Mac%20-%20WPTServ...
- Linux:
https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Linux%20-%20WPTSe...

[falken, 2016-10-24 04:26:49]

Do you have an idea why these are slow? And are you sure adding [ Slow ] will
help?

Slow just extends the timeout to some amount. I'm not even sure the WPT test
harness understands [ Slow ].

Adding Slow is unpreferable, since if the test still times out it'll just make
the bot run more slowly and fail anyway. I'd rather fix the underlying problem.
If we want to keep the bot green immediately, we should add a [ Timeout ]
expectation and remove the expectations as we fix the issues.

[shimazu, 2016-10-25 05:37:50]

Description was changed from

==========
Mark several w3c tests for service workers [ Slow ]

The web platform tests introduced at https://crrev.com/2441963002 are passed on
my local environment while failure on bots.
This patch is to keep the bots green.

BUG=602693
==========

to

==========
Mark several w3c tests for service workers [ Slow ]

The web platform tests introduced at https://crrev.com/2441963002 are passed on
my local environment while failure on bots.
This patch is to keep the bots green.

BUG=602693,658997
==========

[shimazu, 2016-10-25 05:39:10]

Description was changed from

==========
Mark several w3c tests for service workers [ Slow ]

The web platform tests introduced at https://crrev.com/2441963002 are passed on
my local environment while failure on bots.
This patch is to keep the bots green.

BUG=602693,658997
==========

to

==========
Mark several w3c tests for service workers [ Pass Timeout ]

The web platform tests introduced at https://crrev.com/2441963002 are passed
with debug build though they aren't with release build. This patch is to keep
the bots green.

BUG=602693,658997
==========

[shimazu, 2016-10-25 05:40:27]

On 2016/10/24 04:26:49, falken wrote:
> Do you have an idea why these are slow? And are you sure adding [ Slow ] will
> help?
> 
> Slow just extends the timeout to some amount. I'm not even sure the WPT test
> harness understands [ Slow ].
> 
> Adding Slow is unpreferable, since if the test still times out it'll just make
> the bot run more slowly and fail anyway. I'd rather fix the underlying
problem.
> If we want to keep the bot green immediately, we should add a [ Timeout ]
> expectation and remove the expectations as we fix the issues.

Updated the expectations and description.
I'll dig into the cause at another issue: https://crbug.com/658997 .

[shimazu, 2016-10-26 01:40:37]

On 2016/10/25 05:40:27, shimazu wrote:
> On 2016/10/24 04:26:49, falken wrote:
> > Do you have an idea why these are slow? And are you sure adding [ Slow ]
will
> > help?
> > 
> > Slow just extends the timeout to some amount. I'm not even sure the WPT test
> > harness understands [ Slow ].
> > 
> > Adding Slow is unpreferable, since if the test still times out it'll just
make
> > the bot run more slowly and fail anyway. I'd rather fix the underlying
> problem.
> > If we want to keep the bot green immediately, we should add a [ Timeout ]
> > expectation and remove the expectations as we fix the issues.
> 
> Updated the expectations and description.
> I'll dig into the cause at another issue: https://crbug.com/658997 .

As I wrote in https://crbug.com/602693#c23, these tests could pass when the
timeouts was set to longer. Let's use SlowTests for now and fix the w3c tests
later.

[falken, 2016-10-26 01:42:19]

Understood. Looks good but please revise the CL description.

[shimazu, 2016-10-26 01:51:32]

Description was changed from

==========
Mark several w3c tests for service workers [ Pass Timeout ]

The web platform tests introduced at https://crrev.com/2441963002 are passed
with debug build though they aren't with release build. This patch is to keep
the bots green.

BUG=602693,658997
==========

to

==========
Mark several w3c tests for service workers [ Slow ]

Several web platform tests introduced at https://crrev.com/2441963002 are passed
with longer timeout. This patch is to keep
the bots green.

BUG=602693,658997
==========

[shimazu, 2016-10-26 01:52:03]

Description was changed from

==========
Mark several w3c tests for service workers [ Slow ]

Several web platform tests introduced at https://crrev.com/2441963002 are passed
with longer timeout. This patch is to keep
the bots green.

BUG=602693,658997
==========

to

==========
Mark several w3c tests for service workers [ Slow ]

Several web platform tests introduced at https://crrev.com/2441963002 are passed
with longer timeout. This patch is to keep the bots green.

BUG=602693,658997
==========

[shimazu, 2016-10-26 01:52:26]

On 2016/10/26 01:42:19, falken wrote:
> Understood. Looks good but please revise the CL description.

Oops, sorry. Updated.

[falken, 2016-10-26 01:53:00]

lgtm

[shimazu, 2016-10-26 01:59:39]

The CQ bit was checked by shimazu@chromium.org

[commit-bot: I haz the power, 2016-10-26 02:00:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 02:15:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 02:15:49]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shimazu, 2016-10-26 03:23:11]

The CQ bit was checked by shimazu@chromium.org

[commit-bot: I haz the power, 2016-10-26 03:23:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 05:43:23]

Description was changed from

==========
Mark several w3c tests for service workers [ Slow ]

Several web platform tests introduced at https://crrev.com/2441963002 are passed
with longer timeout. This patch is to keep the bots green.

BUG=602693,658997
==========

to

==========
Mark several w3c tests for service workers [ Slow ]

Several web platform tests introduced at https://crrev.com/2441963002 are passed
with longer timeout. This patch is to keep the bots green.

BUG=602693,658997
==========

[commit-bot: I haz the power, 2016-10-26 05:43:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 05:45:28]

Description was changed from

==========
Mark several w3c tests for service workers [ Slow ]

Several web platform tests introduced at https://crrev.com/2441963002 are passed
with longer timeout. This patch is to keep the bots green.

BUG=602693,658997
==========

to

==========
Mark several w3c tests for service workers [ Slow ]

Several web platform tests introduced at https://crrev.com/2441963002 are passed
with longer timeout. This patch is to keep the bots green.

BUG=602693,658997

Committed: https://crrev.com/74e0e4302ff524635ecbef0e45cecbda268e8552
Cr-Commit-Position: refs/heads/master@{#427600}
==========

[commit-bot: I haz the power, 2016-10-26 05:45:29]

Patchset 3 (id:??) landed as
https://crrev.com/74e0e4302ff524635ecbef0e45cecbda268e8552
Cr-Commit-Position: refs/heads/master@{#427600}