Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: ui/compositor/test/in_process_context_factory.cc

Issue 2443003004: cc: Make OutputSurface::BindToClient pure virtual and not return bool (Closed)
Patch Set: bindtoclient-pure-virtual: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/surfaces/direct_output_surface_ozone.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/test/in_process_context_factory.cc
diff --git a/ui/compositor/test/in_process_context_factory.cc b/ui/compositor/test/in_process_context_factory.cc
index 0a5bc53b4ceb073accfb816cbc59a0cfcac8d466..47642dd4993fdb7cec4f3460ea0fa9eddd84c087 100644
--- a/ui/compositor/test/in_process_context_factory.cc
+++ b/ui/compositor/test/in_process_context_factory.cc
@@ -56,8 +56,8 @@ class DirectOutputSurface : public cc::OutputSurface {
~DirectOutputSurface() override {}
// cc::OutputSurface implementation.
- bool BindToClient(cc::OutputSurfaceClient* client) override {
- return OutputSurface::BindToClient(client);
+ void BindToClient(cc::OutputSurfaceClient* client) override {
+ client_ = client;
}
void EnsureBackbuffer() override {}
void DiscardBackbuffer() override {}
@@ -106,6 +106,7 @@ class DirectOutputSurface : public cc::OutputSurface {
private:
void OnSwapBuffersComplete() { client_->DidReceiveSwapBuffersAck(); }
+ cc::OutputSurfaceClient* client_ = nullptr;
base::WeakPtrFactory<DirectOutputSurface> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(DirectOutputSurface);
« no previous file with comments | « services/ui/surfaces/direct_output_surface_ozone.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698