Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Unified Diff: services/ui/surfaces/direct_output_surface.h

Issue 2443003004: cc: Make OutputSurface::BindToClient pure virtual and not return bool (Closed)
Patch Set: bindtoclient-pure-virtual: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/layouttest_support.cc ('k') | services/ui/surfaces/direct_output_surface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/surfaces/direct_output_surface.h
diff --git a/services/ui/surfaces/direct_output_surface.h b/services/ui/surfaces/direct_output_surface.h
index 4d95bbac9fe5878bc5273d3e9585905104bd2d5c..98c09d69004439dd6b57dc6da079db96677b74db 100644
--- a/services/ui/surfaces/direct_output_surface.h
+++ b/services/ui/surfaces/direct_output_surface.h
@@ -29,7 +29,7 @@ class DirectOutputSurface : public cc::OutputSurface,
~DirectOutputSurface() override;
// cc::OutputSurface implementation
- bool BindToClient(cc::OutputSurfaceClient* client) override;
+ void BindToClient(cc::OutputSurfaceClient* client) override;
void EnsureBackbuffer() override;
void DiscardBackbuffer() override;
void BindFramebuffer() override;
@@ -53,6 +53,7 @@ class DirectOutputSurface : public cc::OutputSurface,
private:
void OnSwapBuffersComplete();
+ cc::OutputSurfaceClient* client_ = nullptr;
cc::SyntheticBeginFrameSource* const synthetic_begin_frame_source_;
base::WeakPtrFactory<DirectOutputSurface> weak_ptr_factory_;
};
« no previous file with comments | « content/test/layouttest_support.cc ('k') | services/ui/surfaces/direct_output_surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698