content/browser/compositor/offscreen_browser_compositor_output_surface.cc - Issue 2443003004: cc: Make OutputSurface::BindToClient pure virtual and not return bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/offscreen_browser_compositor_output_surface.cc

Issue 2443003004: cc: Make OutputSurface::BindToClient pure virtual and not return bool (Closed)

Patch Set: bindtoclient-pure-virtual: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/offscreen_browser_compositor_output_surface.h ('k') | content/browser/compositor/reflector_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/offscreen_browser_compositor_output_surface.cc

diff --git a/content/browser/compositor/offscreen_browser_compositor_output_surface.cc b/content/browser/compositor/offscreen_browser_compositor_output_surface.cc

index 8fdff08bfbdc2f41593d49485e166b44bcb59958..a43de0d4d67025c143def01d424609fdbc6e24c1 100644

--- a/content/browser/compositor/offscreen_browser_compositor_output_surface.cc

+++ b/content/browser/compositor/offscreen_browser_compositor_output_surface.cc

@@ -47,6 +47,13 @@ OffscreenBrowserCompositorOutputSurface::

DiscardBackbuffer();

}

+void OffscreenBrowserCompositorOutputSurface::BindToClient(

+ cc::OutputSurfaceClient* client) {

+ DCHECK(client);

+ DCHECK(!client_);

+ client_ = client;

void OffscreenBrowserCompositorOutputSurface::EnsureBackbuffer() {

bool update_source_texture = !reflector_texture_ || reflector_changed_;

reflector_changed_ = false;