content/browser/compositor/gpu_browser_compositor_output_surface.h - Issue 2443003004: cc: Make OutputSurface::BindToClient pure virtual and not return bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/gpu_browser_compositor_output_surface.h

Issue 2443003004: cc: Make OutputSurface::BindToClient pure virtual and not return bool (Closed)

Patch Set: bindtoclient-pure-virtual: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/compositor/gpu_browser_compositor_output_surface.h

diff --git a/content/browser/compositor/gpu_browser_compositor_output_surface.h b/content/browser/compositor/gpu_browser_compositor_output_surface.h

index 6f167e4a382326112489c96e23ba53594feafd1d..e91a40d39b621c82abd03b9b572c6909f891e92b 100644

--- a/content/browser/compositor/gpu_browser_compositor_output_surface.h

+++ b/content/browser/compositor/gpu_browser_compositor_output_surface.h

@@ -60,7 +60,7 @@ class GpuBrowserCompositorOutputSurface

#endif

// cc::OutputSurface implementation.

- bool BindToClient(cc::OutputSurfaceClient* client) override;

+ void BindToClient(cc::OutputSurfaceClient* client) override;

void EnsureBackbuffer() override;

void DiscardBackbuffer() override;

void BindFramebuffer() override;

@@ -77,6 +77,7 @@ class GpuBrowserCompositorOutputSurface

protected:

gpu::CommandBufferProxyImpl* GetCommandBufferProxy();

+ cc::OutputSurfaceClient* client_ = nullptr;

std::unique_ptr<ReflectorTexture> reflector_texture_;

base::WeakPtrFactory<GpuBrowserCompositorOutputSurface> weak_ptr_factory_;