Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3489)

Unified Diff: cc/test/fake_output_surface.cc

Issue 2443003004: cc: Make OutputSurface::BindToClient pure virtual and not return bool (Closed)
Patch Set: bindtoclient-pure-virtual: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/fake_output_surface.h ('k') | cc/test/fake_output_surface_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/fake_output_surface.cc
diff --git a/cc/test/fake_output_surface.cc b/cc/test/fake_output_surface.cc
index 362c59d790f1668d8c7ee7a222a36fda40c23df0..c3dbacd04ff3518680fc22271a8bb98f5dc1614c 100644
--- a/cc/test/fake_output_surface.cc
+++ b/cc/test/fake_output_surface.cc
@@ -72,13 +72,10 @@ uint32_t FakeOutputSurface::GetFramebufferCopyTextureFormat() {
return GL_RGB;
}
-bool FakeOutputSurface::BindToClient(OutputSurfaceClient* client) {
- if (OutputSurface::BindToClient(client)) {
- client_ = client;
- return true;
- } else {
- return false;
- }
+void FakeOutputSurface::BindToClient(OutputSurfaceClient* client) {
+ DCHECK(client);
+ DCHECK(!client_);
+ client_ = client;
}
bool FakeOutputSurface::HasExternalStencilTest() const {
« no previous file with comments | « cc/test/fake_output_surface.h ('k') | cc/test/fake_output_surface_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698