content/browser/compositor/software_browser_compositor_output_surface_unittest.cc - Issue 2443003004: cc: Make OutputSurface::BindToClient pure virtual and not return bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

Issue 2443003004: cc: Make OutputSurface::BindToClient pure virtual and not return bool (Closed)

Patch Set: bindtoclient-pure-virtual: . Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/output/gl_renderer_unittest.cc ('K') | « content/browser/compositor/software_browser_compositor_output_surface.cc ('k') | content/browser/renderer_host/compositor_impl_android.h » ('j') | content/browser/renderer_host/compositor_impl_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

diff --git a/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc b/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

index f2e12a4da995a525c1a7648db0570632e2ccc4ec..a91c8326a45bf704bcd8a837702513aef70afdc8 100644

--- a/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

+++ b/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

@@ -118,7 +118,7 @@ TEST_F(SoftwareBrowserCompositorOutputSurfaceTest, NoVSyncProvider) {

std::unique_ptr<cc::SoftwareOutputDevice> software_device(

new cc::SoftwareOutputDevice());

output_surface_ = CreateSurface(std::move(software_device));

- CHECK(output_surface_->BindToClient(&output_surface_client));

+ output_surface_->BindToClient(&output_surface_client);

output_surface_->SwapBuffers(cc::OutputSurfaceFrame());

EXPECT_EQ(NULL, output_surface_->software_device()->GetVSyncProvider());

@@ -129,7 +129,7 @@ TEST_F(SoftwareBrowserCompositorOutputSurfaceTest, VSyncProviderUpdates) {

std::unique_ptr<cc::SoftwareOutputDevice> software_device(

new FakeSoftwareOutputDevice());

output_surface_ = CreateSurface(std::move(software_device));

- CHECK(output_surface_->BindToClient(&output_surface_client));

+ output_surface_->BindToClient(&output_surface_client);

FakeVSyncProvider* vsync_provider = static_cast<FakeVSyncProvider*>(

output_surface_->software_device()->GetVSyncProvider());