Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: blimp/client/support/compositor/blimp_embedder_compositor.cc

Issue 2443003004: cc: Make OutputSurface::BindToClient pure virtual and not return bool (Closed)
Patch Set: bindtoclient-pure-virtual: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/support/compositor/blimp_embedder_compositor.cc
diff --git a/blimp/client/support/compositor/blimp_embedder_compositor.cc b/blimp/client/support/compositor/blimp_embedder_compositor.cc
index f8116dced4d77d54370a5aa925b4dfe935741825..da0e4c8d7b9febbabc28e1ce14549f7055eb69b5 100644
--- a/blimp/client/support/compositor/blimp_embedder_compositor.cc
+++ b/blimp/client/support/compositor/blimp_embedder_compositor.cc
@@ -51,6 +51,9 @@ class DisplayOutputSurface : public cc::OutputSurface {
~DisplayOutputSurface() override = default;
// cc::OutputSurface implementation
+ void BindToClient(cc::OutputSurfaceClient* client) override {
+ client_ = client;
+ }
void EnsureBackbuffer() override {}
void DiscardBackbuffer() override {
context_provider()->ContextGL()->DiscardBackbufferCHROMIUM();
@@ -90,6 +93,7 @@ class DisplayOutputSurface : public cc::OutputSurface {
private:
void SwapBuffersCallback() { client_->DidReceiveSwapBuffersAck(); }
+ cc::OutputSurfaceClient* client_ = nullptr;
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
base::WeakPtrFactory<DisplayOutputSurface> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698