Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: content/browser/compositor/mus_browser_compositor_output_surface.h

Issue 2443003004: cc: Make OutputSurface::BindToClient pure virtual and not return bool (Closed)
Patch Set: bindtoclient-pure-virtual: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_COMPOSITOR_MUS_BROWSER_COMPOSITOR_OUTPUT_SURFACE_H_ 5 #ifndef CONTENT_BROWSER_COMPOSITOR_MUS_BROWSER_COMPOSITOR_OUTPUT_SURFACE_H_
6 #define CONTENT_BROWSER_COMPOSITOR_MUS_BROWSER_COMPOSITOR_OUTPUT_SURFACE_H_ 6 #define CONTENT_BROWSER_COMPOSITOR_MUS_BROWSER_COMPOSITOR_OUTPUT_SURFACE_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 23 matching lines...) Expand all
34 scoped_refptr<ui::CompositorVSyncManager> vsync_manager, 34 scoped_refptr<ui::CompositorVSyncManager> vsync_manager,
35 cc::SyntheticBeginFrameSource* begin_frame_source, 35 cc::SyntheticBeginFrameSource* begin_frame_source,
36 std::unique_ptr<display_compositor::CompositorOverlayCandidateValidator> 36 std::unique_ptr<display_compositor::CompositorOverlayCandidateValidator>
37 overlay_candidate_validator); 37 overlay_candidate_validator);
38 38
39 ~MusBrowserCompositorOutputSurface() override; 39 ~MusBrowserCompositorOutputSurface() override;
40 40
41 protected: 41 protected:
42 // cc::OutputSurface implementation. 42 // cc::OutputSurface implementation.
43 void SwapBuffers(cc::OutputSurfaceFrame frame) override; 43 void SwapBuffers(cc::OutputSurfaceFrame frame) override;
44 bool BindToClient(cc::OutputSurfaceClient* client) override;
45 44
46 // cc::CompositorFrameSinkClient: 45 // cc::CompositorFrameSinkClient:
47 void SetBeginFrameSource(cc::BeginFrameSource* source) override; 46 void SetBeginFrameSource(cc::BeginFrameSource* source) override;
48 void ReclaimResources(const cc::ReturnedResourceArray& resources) override; 47 void ReclaimResources(const cc::ReturnedResourceArray& resources) override;
49 void SetTreeActivationCallback(const base::Closure& callback) override; 48 void SetTreeActivationCallback(const base::Closure& callback) override;
50 void DidReceiveCompositorFrameAck() override; 49 void DidReceiveCompositorFrameAck() override;
51 void DidLoseCompositorFrameSink() override; 50 void DidLoseCompositorFrameSink() override;
52 void OnDraw(const gfx::Transform& transform, 51 void OnDraw(const gfx::Transform& transform,
53 const gfx::Rect& viewport, 52 const gfx::Rect& viewport,
54 bool resourceless_software_draw) override; 53 bool resourceless_software_draw) override;
(...skipping 11 matching lines...) Expand all
66 std::unique_ptr<ui::WindowCompositorFrameSink> ui_compositor_frame_sink_; 65 std::unique_ptr<ui::WindowCompositorFrameSink> ui_compositor_frame_sink_;
67 std::vector<uint32_t> free_resource_ids_; 66 std::vector<uint32_t> free_resource_ids_;
68 std::vector<gpu::Mailbox> mailboxes_; 67 std::vector<gpu::Mailbox> mailboxes_;
69 68
70 DISALLOW_COPY_AND_ASSIGN(MusBrowserCompositorOutputSurface); 69 DISALLOW_COPY_AND_ASSIGN(MusBrowserCompositorOutputSurface);
71 }; 70 };
72 71
73 } // namespace content 72 } // namespace content
74 73
75 #endif // CONTENT_BROWSER_COMPOSITOR_MUS_BROWSER_COMPOSITOR_OUTPUT_SURFACE_H_ 74 #endif // CONTENT_BROWSER_COMPOSITOR_MUS_BROWSER_COMPOSITOR_OUTPUT_SURFACE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698