Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Side by Side Diff: cc/test/pixel_test_output_surface.h

Issue 2443003004: cc: Make OutputSurface::BindToClient pure virtual and not return bool (Closed)
Patch Set: bindtoclient-pure-virtual: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/test/layer_tree_pixel_test.cc ('k') | cc/test/pixel_test_output_surface.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_TEST_PIXEL_TEST_OUTPUT_SURFACE_H_ 5 #ifndef CC_TEST_PIXEL_TEST_OUTPUT_SURFACE_H_
6 #define CC_TEST_PIXEL_TEST_OUTPUT_SURFACE_H_ 6 #define CC_TEST_PIXEL_TEST_OUTPUT_SURFACE_H_
7 7
8 #include "base/memory/weak_ptr.h" 8 #include "base/memory/weak_ptr.h"
9 #include "cc/output/output_surface.h" 9 #include "cc/output/output_surface.h"
10 10
11 namespace cc { 11 namespace cc {
12 12
13 class PixelTestOutputSurface : public OutputSurface { 13 class PixelTestOutputSurface : public OutputSurface {
14 public: 14 public:
15 explicit PixelTestOutputSurface( 15 explicit PixelTestOutputSurface(
16 scoped_refptr<ContextProvider> context_provider, 16 scoped_refptr<ContextProvider> context_provider,
17 bool flipped_output_surface); 17 bool flipped_output_surface);
18 explicit PixelTestOutputSurface( 18 explicit PixelTestOutputSurface(
19 std::unique_ptr<SoftwareOutputDevice> software_device); 19 std::unique_ptr<SoftwareOutputDevice> software_device);
20 ~PixelTestOutputSurface() override; 20 ~PixelTestOutputSurface() override;
21 21
22 // OutputSurface implementation. 22 // OutputSurface implementation.
23 void BindToClient(OutputSurfaceClient* client) override;
23 void EnsureBackbuffer() override; 24 void EnsureBackbuffer() override;
24 void DiscardBackbuffer() override; 25 void DiscardBackbuffer() override;
25 void BindFramebuffer() override; 26 void BindFramebuffer() override;
26 void Reshape(const gfx::Size& size, 27 void Reshape(const gfx::Size& size,
27 float device_scale_factor, 28 float device_scale_factor,
28 const gfx::ColorSpace& color_space, 29 const gfx::ColorSpace& color_space,
29 bool has_alpha) override; 30 bool has_alpha) override;
30 bool HasExternalStencilTest() const override; 31 bool HasExternalStencilTest() const override;
31 void ApplyExternalStencil() override; 32 void ApplyExternalStencil() override;
32 void SwapBuffers(OutputSurfaceFrame frame) override; 33 void SwapBuffers(OutputSurfaceFrame frame) override;
33 OverlayCandidateValidator* GetOverlayCandidateValidator() const override; 34 OverlayCandidateValidator* GetOverlayCandidateValidator() const override;
34 bool IsDisplayedAsOverlayPlane() const override; 35 bool IsDisplayedAsOverlayPlane() const override;
35 unsigned GetOverlayTextureId() const override; 36 unsigned GetOverlayTextureId() const override;
36 bool SurfaceIsSuspendForRecycle() const override; 37 bool SurfaceIsSuspendForRecycle() const override;
37 uint32_t GetFramebufferCopyTextureFormat() override; 38 uint32_t GetFramebufferCopyTextureFormat() override;
38 39
39 void set_has_external_stencil_test(bool has_test) { 40 void set_has_external_stencil_test(bool has_test) {
40 external_stencil_test_ = has_test; 41 external_stencil_test_ = has_test;
41 } 42 }
42 43
43 private: 44 private:
44 void SwapBuffersCallback(); 45 void SwapBuffersCallback();
45 46
46 bool external_stencil_test_ = false; 47 bool external_stencil_test_ = false;
48 OutputSurfaceClient* client_ = nullptr;
47 base::WeakPtrFactory<PixelTestOutputSurface> weak_ptr_factory_; 49 base::WeakPtrFactory<PixelTestOutputSurface> weak_ptr_factory_;
48 }; 50 };
49 51
50 } // namespace cc 52 } // namespace cc
51 53
52 #endif // CC_TEST_PIXEL_TEST_OUTPUT_SURFACE_H_ 54 #endif // CC_TEST_PIXEL_TEST_OUTPUT_SURFACE_H_
OLDNEW
« no previous file with comments | « cc/test/layer_tree_pixel_test.cc ('k') | cc/test/pixel_test_output_surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698