cc: Make OutputSurface::BindToClient pure virtual and not return bool

cc/test/fake_output_surface.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TEST_FAKE_OUTPUT_SURFACE_H_
 #define CC_TEST_FAKE_OUTPUT_SURFACE_H_
 
 #include <stddef.h>
 
 #include "base/callback.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/time/time.h"
 #include "cc/output/begin_frame_args.h"
 #include "cc/output/output_surface.h"
 #include "cc/output/output_surface_frame.h"
 #include "cc/output/software_output_device.h"
 #include "cc/test/test_context_provider.h"
 #include "cc/test/test_gles2_interface.h"
 #include "cc/test/test_web_graphics_context_3d.h"
 
 namespace cc {
 
 class FakeOutputSurface : public OutputSurface {
  public:
   ~FakeOutputSurface() override;
 
   static std::unique_ptr<FakeOutputSurface> Create3d() {
-    return base::WrapUnique(
-        new FakeOutputSurface(TestContextProvider::Create()));
+    auto provider = TestContextProvider::Create();
+    provider->BindToCurrentThread();
+    return base::WrapUnique(new FakeOutputSurface(std::move(provider)));
   }
 
   static std::unique_ptr<FakeOutputSurface> Create3d(
       scoped_refptr<ContextProvider> context_provider) {
     return base::WrapUnique(new FakeOutputSurface(context_provider));
   }
 
-  static std::unique_ptr<FakeOutputSurface> Create3d(
-      std::unique_ptr<TestGLES2Interface> gl) {
-    return base::WrapUnique(
-        new FakeOutputSurface(TestContextProvider::Create(std::move(gl))));
-  }
-
-  static std::unique_ptr<FakeOutputSurface> Create3d(
-      std::unique_ptr<TestWebGraphicsContext3D> context) {
-    return base::WrapUnique(
-        new FakeOutputSurface(TestContextProvider::Create(std::move(context))));
-  }
-
   static std::unique_ptr<FakeOutputSurface> CreateSoftware(
       std::unique_ptr<SoftwareOutputDevice> software_device) {
     return base::WrapUnique(new FakeOutputSurface(std::move(software_device)));
   }
 
   static std::unique_ptr<FakeOutputSurface> CreateOffscreen(
-      std::unique_ptr<TestWebGraphicsContext3D> context) {
-    auto surface = base::WrapUnique(
-        new FakeOutputSurface(TestContextProvider::Create(std::move(context))));
+      scoped_refptr<ContextProvider> context_provider) {
+    auto surface =
+        base::WrapUnique(new FakeOutputSurface(std::move(context_provider)));
     surface->capabilities_.uses_default_gl_framebuffer = false;
     return surface;
   }
 
   void set_max_frames_pending(int max) {
     capabilities_.max_frames_pending = max;
   }
 
   OutputSurfaceFrame* last_sent_frame() { return last_sent_frame_.get(); }
   size_t num_sent_frames() { return num_sent_frames_; }
 
   OutputSurfaceClient* client() { return client_; }
 
-  bool BindToClient(OutputSurfaceClient* client) override;
+  void BindToClient(OutputSurfaceClient* client) override;
   void EnsureBackbuffer() override {}
   void DiscardBackbuffer() override {}
   void BindFramebuffer() override;
   void Reshape(const gfx::Size& size,
                float device_scale_factor,
                const gfx::ColorSpace& color_space,
                bool has_alpha) override;
   void SwapBuffers(OutputSurfaceFrame frame) override;
   uint32_t GetFramebufferCopyTextureFormat() override;
   bool HasExternalStencilTest() const override;
@@ skipping 43 matching lines @@
 
  private:
   void SwapBuffersAck();
 
   base::WeakPtrFactory<FakeOutputSurface> weak_ptr_factory_;
 };
 
 }  // namespace cc
 
 #endif  // CC_TEST_FAKE_OUTPUT_SURFACE_H_