Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2443003003: [interpreter] Make --trace-codegen also trace bytecode. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Make --trace-codegen also trace bytecode. This ensures that both --trace-codegen as well as --print-ast work for Ignition and print traces for generated bytecode as well. Here we do consider "bytecode" to be "code" as well for tracing purposes. R=rmcilroy@chromium.org Committed: https://crrev.com/65e68c66afe6d4d2ff62e775558cb0d35cb013bd Cr-Commit-Position: refs/heads/master@{#40531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/interpreter/interpreter.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 1 month ago (2016-10-24 11:53:50 UTC) #3
rmcilroy
lgtm
4 years, 1 month ago (2016-10-24 12:17:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443003003/1
4 years, 1 month ago (2016-10-24 12:29:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 12:33:22 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:11:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65e68c66afe6d4d2ff62e775558cb0d35cb013bd
Cr-Commit-Position: refs/heads/master@{#40531}

Powered by Google App Engine
This is Rietveld 408576698