Source/core/svg/SVGImageElement.cpp - Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGImageElement.cpp

Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGImageElement.cpp

diff --git a/Source/core/svg/SVGImageElement.cpp b/Source/core/svg/SVGImageElement.cpp

index d2ce3c0db59d48b30af873a960988f2d968b09a5..8c0aee7a6cd2ec632878016167d0409d6953a8bb 100644

--- a/Source/core/svg/SVGImageElement.cpp

+++ b/Source/core/svg/SVGImageElement.cpp

@@ -203,9 +203,9 @@ bool SVGImageElement::haveLoadedRequiredResources()

return !externalResourcesRequiredBaseValue() || !m_imageLoader.hasPendingActivity();

}

-void SVGImageElement::attach(const AttachContext& context)

+void SVGImageElement::createRenderTree(const AttachContext& context)

{

- SVGGraphicsElement::attach(context);

+ SVGGraphicsElement::createRenderTree(context);

if (RenderSVGImage* imageObj = toRenderSVGImage(renderer())) {

if (imageObj->imageResource()->hasImage())