Source/core/page/Frame.cpp - Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/Frame.cpp

Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/Frame.cpp

diff --git a/Source/core/page/Frame.cpp b/Source/core/page/Frame.cpp

index 7e1e409b33df21623d2aadbf9e3ee0d334fc5c01..4f8b7ab3c749ef49c37a5df374ee1014fbda7b32 100644

--- a/Source/core/page/Frame.cpp

+++ b/Source/core/page/Frame.cpp

@@ -181,7 +181,7 @@ void Frame::removeDestructionObserver(FrameDestructionObserver* observer)

void Frame::setView(PassRefPtr<FrameView> view)

{

- // We the custom scroll bars as early as possible to prevent m_doc->detach()

+ // We the custom scroll bars as early as possible to prevent m_doc->destroyRenderTree()

// from messing with the view such that its scroll bars won't be torn down.

// FIXME: We should revisit this.

if (m_view)