Source/core/html/HTMLPlugInImageElement.h - Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLPlugInImageElement.h

Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLPlugInImageElement.h

diff --git a/Source/core/html/HTMLPlugInImageElement.h b/Source/core/html/HTMLPlugInImageElement.h

index f994810aa9f880ff926540fe881164135af562eb..e396c050413ad1572e4f195ea31f975fc007c6aa 100644

--- a/Source/core/html/HTMLPlugInImageElement.h

+++ b/Source/core/html/HTMLPlugInImageElement.h

@@ -85,8 +85,8 @@ protected:

KURL m_loadedUrl;

static void updateWidgetCallback(Node*);

- virtual void attach(const AttachContext& = AttachContext()) OVERRIDE;

- virtual void detach(const AttachContext& = AttachContext()) OVERRIDE;

+ virtual void createRenderTree(const AttachContext& = AttachContext()) OVERRIDE;

+ virtual void destroyRenderTree(const AttachContext& = AttachContext()) OVERRIDE;

bool allowedToLoadFrameURL(const String& url);

bool wouldLoadAsNetscapePlugin(const String& url, const String& serviceType);