Source/core/html/HTMLPlugInElement.cpp - Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLPlugInElement.cpp

Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLPlugInElement.cpp

diff --git a/Source/core/html/HTMLPlugInElement.cpp b/Source/core/html/HTMLPlugInElement.cpp

index 9af98d1fab565b2b0c90ccc829aa9367897b7dc7..3fb6fcd82477571aacc6bd3982c4490d35a37c20 100644

--- a/Source/core/html/HTMLPlugInElement.cpp

+++ b/Source/core/html/HTMLPlugInElement.cpp

@@ -88,7 +88,7 @@ void HTMLPlugInElement::removeAllEventListeners()

}

-void HTMLPlugInElement::detach(const AttachContext& context)

+void HTMLPlugInElement::destroyRenderTree(const AttachContext& context)

{

m_instance.clear();

@@ -103,7 +103,7 @@ void HTMLPlugInElement::detach(const AttachContext& context)

m_NPObject = 0;

}

- HTMLFrameOwnerElement::detach(context);

+ HTMLFrameOwnerElement::destroyRenderTree(context);

}

void HTMLPlugInElement::resetInstance()