Source/core/html/HTMLOptionElement.h - Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionElement.h

Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLOptionElement.h

diff --git a/Source/core/html/HTMLOptionElement.h b/Source/core/html/HTMLOptionElement.h

index c2e55a3f37b987303a3c2cc403a0826ce729461f..f41402cf23274522650d5cfd1d6c26643eb23f67 100644

--- a/Source/core/html/HTMLOptionElement.h

+++ b/Source/core/html/HTMLOptionElement.h

@@ -70,8 +70,8 @@ private:

virtual bool rendererIsFocusable() const OVERRIDE;

virtual bool rendererIsNeeded(const RenderStyle&) { return false; }

- virtual void attach(const AttachContext& = AttachContext()) OVERRIDE;

- virtual void detach(const AttachContext& = AttachContext()) OVERRIDE;

+ virtual void createRenderTree(const AttachContext& = AttachContext()) OVERRIDE;

+ virtual void destroyRenderTree(const AttachContext& = AttachContext()) OVERRIDE;

virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERRIDE;