Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: Source/core/html/HTMLOptionElement.cpp

Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLOptionElement.cpp
diff --git a/Source/core/html/HTMLOptionElement.cpp b/Source/core/html/HTMLOptionElement.cpp
index dbe4d00c1484d4c4bbfa5855a156135888e0b088..f927685a62fc470130ecdafa17966bcdf283f0ba 100644
--- a/Source/core/html/HTMLOptionElement.cpp
+++ b/Source/core/html/HTMLOptionElement.cpp
@@ -86,9 +86,9 @@ PassRefPtr<HTMLOptionElement> HTMLOptionElement::createForJSConstructor(Document
return element.release();
}
-void HTMLOptionElement::attach(const AttachContext& context)
+void HTMLOptionElement::createRenderTree(const AttachContext& context)
{
- HTMLElement::attach(context);
+ HTMLElement::createRenderTree(context);
// If after attaching nothing called styleForRenderer() on this node we
// manually cache the value. This happens if our parent doesn't have a
// renderer like <optgroup> or if it doesn't allow children like <select>.
@@ -96,10 +96,10 @@ void HTMLOptionElement::attach(const AttachContext& context)
updateNonRenderStyle();
}
-void HTMLOptionElement::detach(const AttachContext& context)
+void HTMLOptionElement::destroyRenderTree(const AttachContext& context)
{
m_style.clear();
- HTMLElement::detach(context);
+ HTMLElement::destroyRenderTree(context);
}
bool HTMLOptionElement::rendererIsFocusable() const

Powered by Google App Engine
This is Rietveld 408576698