Source/core/html/HTMLMediaElement.cpp - Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 7ded8f1ae11459baab8be9f532b593824b2becdc..183ff45cbdc1b8e360c94a1769c146c930458245 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -546,11 +546,11 @@ void HTMLMediaElement::removedFrom(ContainerNode* insertionPoint)

HTMLElement::removedFrom(insertionPoint);

}

-void HTMLMediaElement::attach(const AttachContext& context)

+void HTMLMediaElement::createRenderTree(const AttachContext& context)

{

ASSERT(!attached());

- HTMLElement::attach(context);

+ HTMLElement::createRenderTree(context);

if (renderer())

renderer()->updateFromElement();