Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: Source/core/dom/shadow/ShadowRoot.cpp

Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/shadow/ShadowRoot.cpp
diff --git a/Source/core/dom/shadow/ShadowRoot.cpp b/Source/core/dom/shadow/ShadowRoot.cpp
index bb0f5a1aabd36064f551e21bdb741564c6b64c71..f854574f12686a547f243684883d935802612861 100644
--- a/Source/core/dom/shadow/ShadowRoot.cpp
+++ b/Source/core/dom/shadow/ShadowRoot.cpp
@@ -171,7 +171,7 @@ void ShadowRoot::recalcStyle(StyleRecalcChange change)
return;
}
- // When we're set to lazyAttach we'll have a SubtreeStyleChange and we'll need
+ // When we're set to scheduleRenderTreeCreation we'll have a SubtreeStyleChange and we'll need
// to promote the change to a Force for all our descendants so they get a
// recalc and will attach.
if (styleChangeType() >= SubtreeStyleChange)
@@ -187,7 +187,7 @@ void ShadowRoot::recalcStyle(StyleRecalcChange change)
if (child->isTextNode()) {
if (forceReattachOfAnyWhitespaceSibling && toText(child)->containsOnlyWhitespace())
- child->reattach();
+ child->recreateRenderTree();
else
didReattach = toText(child)->recalcTextStyle(change);
} else if (child->isElementNode() && shouldRecalcStyle(change, child)) {
@@ -251,11 +251,11 @@ void ShadowRoot::setResetStyleInheritance(bool value)
setNeedsStyleRecalc();
}
-void ShadowRoot::attach(const AttachContext& context)
+void ShadowRoot::createRenderTree(const AttachContext& context)
{
StyleResolver* styleResolver = document().styleResolver();
styleResolver->pushParentShadowRoot(*this);
- DocumentFragment::attach(context);
+ DocumentFragment::createRenderTree(context);
styleResolver->popParentShadowRoot(*this);
}

Powered by Google App Engine
This is Rietveld 408576698