Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: Source/core/dom/ContainerNodeAlgorithms.h

Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/ContainerNodeAlgorithms.h
diff --git a/Source/core/dom/ContainerNodeAlgorithms.h b/Source/core/dom/ContainerNodeAlgorithms.h
index d8910cfb7da6a59c7007091e0e2366946b7e9cbb..55f4145f9ad9bb841b23f9ffbef98132452be7f5 100644
--- a/Source/core/dom/ContainerNodeAlgorithms.h
+++ b/Source/core/dom/ContainerNodeAlgorithms.h
@@ -223,13 +223,13 @@ inline void ChildNodeInsertionNotifier::notify(Node* node)
else if (node->isContainerNode())
notifyNodeInsertedIntoTree(toContainerNode(node));
- // Script runs in didNotifySubtreeInsertions so we should lazy attach before
- // to ensure that triggering a style recalc in script attaches all nodes that
- // were inserted.
- // FIXME: We should merge the lazy attach logic into the tree traversal in
+ // Script runs in didNotifySubtreeInsertions so we should schedule the render tree
+ // construction for the nodes before to ensure that triggering a style recalc in
+ // script attaches all nodes that were inserted.
+ // FIXME: We should merge the scheduling logic into the tree traversal in
// notifyNodeInsertedIntoDocument.
if (!node->attached() && node->parentNode() && node->parentNode()->attached())
- node->lazyAttach();
+ node->scheduleRenderTreeCreation();
for (size_t i = 0; i < m_postInsertionNotificationTargets.size(); ++i) {
Node* node = m_postInsertionNotificationTargets[i].get();

Powered by Google App Engine
This is Rietveld 408576698