Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: Source/core/dom/ContainerNode.h

Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/ContainerNode.cpp » ('j') | Source/core/dom/Node.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ContainerNode.h
diff --git a/Source/core/dom/ContainerNode.h b/Source/core/dom/ContainerNode.h
index 80b9c88c0ab865503673206d6d3bd014a70fc0ea..6d90cc94879babb26cd60baee6e4ca85c0e6df74 100644
--- a/Source/core/dom/ContainerNode.h
+++ b/Source/core/dom/ContainerNode.h
@@ -113,8 +113,8 @@ public:
void cloneChildNodes(ContainerNode* clone);
- virtual void attach(const AttachContext& = AttachContext()) OVERRIDE;
- virtual void detach(const AttachContext& = AttachContext()) OVERRIDE;
+ virtual void createRenderTree(const AttachContext& = AttachContext()) OVERRIDE;
+ virtual void destroyRenderTree(const AttachContext& = AttachContext()) OVERRIDE;
virtual LayoutRect boundingBox() const OVERRIDE;
virtual void setFocus(bool) OVERRIDE;
virtual void setActive(bool active = true, bool pause = false) OVERRIDE;
@@ -184,27 +184,6 @@ inline ContainerNode::ContainerNode(TreeScope* treeScope, ConstructionType type)
{
}
-inline void ContainerNode::attachChildren(const AttachContext& context)
-{
- AttachContext childrenContext(context);
- childrenContext.resolvedStyle = 0;
-
- for (Node* child = firstChild(); child; child = child->nextSibling()) {
- ASSERT(!child->attached() || childAttachedAllowedWhenAttachingChildren(this));
- if (!child->attached())
- child->attach(childrenContext);
- }
-}
-
-inline void ContainerNode::detachChildren(const AttachContext& context)
-{
- AttachContext childrenContext(context);
- childrenContext.resolvedStyle = 0;
-
- for (Node* child = firstChild(); child; child = child->nextSibling())
- child->detach(childrenContext);
-}
-
inline unsigned Node::childNodeCount() const
{
if (!isContainerNode())
« no previous file with comments | « no previous file | Source/core/dom/ContainerNode.cpp » ('j') | Source/core/dom/Node.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698