Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2442933002: Create and apply ViewsInteractiveUITestBase (Closed)

Created:
4 years, 2 months ago by Qiang(Joe) Xu
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create and apply ViewsInteractiveUITestBase BUG=658124 TEST=self sustained Committed: https://crrev.com/713c5ab48ce2a75a99927f1da48c1ff0477eda84 Cr-Commit-Position: refs/heads/master@{#427191}

Patch Set 1 #

Patch Set 2 : move test base to ui/views/test_support #

Patch Set 3 : add class comment #

Total comments: 4

Patch Set 4 : based on comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -93 lines) Patch
M ui/views/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/corewm/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/desktop_capture_controller_unittest.cc View 1 2 3 2 chunks +2 lines, -20 lines 0 comments Download
A ui/views/test/views_interactive_ui_test_base.h View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
A ui/views/test/views_interactive_ui_test_base.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11_interactive_uitest.cc View 3 chunks +4 lines, -16 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc View 4 chunks +5 lines, -17 lines 0 comments Download
M ui/views/widget/native_widget_aura_interactive_uitest.cc View 1 2 3 4 chunks +9 lines, -30 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
Qiang(Joe) Xu
Hi Scott, please take a look, thanks! There is one place which is not changed: ...
4 years, 1 month ago (2016-10-24 18:36:34 UTC) #9
sky
LGTM https://codereview.chromium.org/2442933002/diff/40001/ui/views/corewm/desktop_capture_controller_unittest.cc File ui/views/corewm/desktop_capture_controller_unittest.cc (right): https://codereview.chromium.org/2442933002/diff/40001/ui/views/corewm/desktop_capture_controller_unittest.cc#newcode27 ui/views/corewm/desktop_capture_controller_unittest.cc:27: typedef ViewsInteractiveUITestBase DesktopCaptureControllerTest; typedef->using https://codereview.chromium.org/2442933002/diff/40001/ui/views/test/views_interactive_ui_test_base.h File ui/views/test/views_interactive_ui_test_base.h (right): ...
4 years, 1 month ago (2016-10-24 20:05:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442933002/60001
4 years, 1 month ago (2016-10-24 20:33:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/93237)
4 years, 1 month ago (2016-10-24 20:43:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442933002/60001
4 years, 1 month ago (2016-10-24 21:01:17 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/93272)
4 years, 1 month ago (2016-10-24 21:10:06 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442933002/60001
4 years, 1 month ago (2016-10-24 23:08:40 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-25 00:40:40 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 00:43:29 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/713c5ab48ce2a75a99927f1da48c1ff0477eda84
Cr-Commit-Position: refs/heads/master@{#427191}

Powered by Google App Engine
This is Rietveld 408576698