Revert revision 27860

sdk/lib/_internal/pub/test/serve/utils.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS d.file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pub_tests;
 
 import 'dart:async';
 
 import 'package:http/http.dart' as http;
 import 'package:scheduled_test/scheduled_process.dart';
@@ skipping 74 matching lines @@
 """;
 }
 
 /// Schedules starting the "pub serve" process.
 ///
 /// If [shouldInstallFirst] is `true`, validates that pub install is run first.
 ///
 /// Returns the `pub serve` process.
 ScheduledProcess startPubServe({bool shouldInstallFirst: false}) {
   // Use port 0 to get an ephemeral port.
-  _pubServer = startPub(args: ["serve", "--port=0", "--hostname=127.0.0.1"]);
+  _pubServer = startPub(args: ["serve", "--port=0"]);
 
   if (shouldInstallFirst) {
     expect(_pubServer.nextLine(),
         completion(startsWith("Dependencies have changed")));
     expect(_pubServer.nextLine(),
         completion(startsWith("Resolving dependencies...")));
     expect(_pubServer.nextLine(),
         completion(equals("Dependencies installed!")));
   }
 
   expect(_pubServer.nextLine().then(_parsePort), completes);
   return _pubServer;
 }
 
-/// Parses the port number from the "Serving blah on 127.0.0.1:1234" line
+/// Parses the port number from the "Serving blah on localhost:1234" line
 /// printed by pub serve.
 void _parsePort(String line) {
-  var match = new RegExp(r"127\.0\.0\.1:(\d+)").firstMatch(line);
+  var match = new RegExp(r"localhost:(\d+)").firstMatch(line);
   assert(match != null);
   _port = int.parse(match[1]);
 }
 
 void endPubServe() {
   _pubServer.kill();
 }
 
 /// Schedules an HTTP request to the running pub server with [urlPath] and
 /// verifies that it responds with [expected].
 void requestShouldSucceed(String urlPath, String expected) {
   schedule(() {
-    return http.get("http://127.0.0.1:$_port/$urlPath").then((response) {
+    return http.get("http://localhost:$_port/$urlPath").then((response) {
       expect(response.body, equals(expected));
     });
   }, "request $urlPath");
 }
 
 /// Schedules an HTTP request to the running pub server with [urlPath] and
 /// verifies that it responds with a 404.
 void requestShould404(String urlPath) {
   schedule(() {
-    return http.get("http://127.0.0.1:$_port/$urlPath").then((response) {
+    return http.get("http://localhost:$_port/$urlPath").then((response) {
       expect(response.statusCode, equals(404));
     });
   }, "request $urlPath");
 }
 
 /// Schedules an HTTP POST to the running pub server with [urlPath] and verifies
 /// that it responds with a 405.
 void postShould405(String urlPath) {
   schedule(() {
-    return http.post("http://127.0.0.1:$_port/$urlPath").then((response) {
+    return http.post("http://localhost:$_port/$urlPath").then((response) {
       expect(response.statusCode, equals(405));
     });
   }, "request $urlPath");
 }
 
 /// Reads lines from pub serve's stdout until it prints the build success
 /// message.
 ///
 /// The schedule will not proceed until the output is found. If not found, it
 /// will eventually time out.
 void waitForBuildSuccess() {
   nextLine() {
     return _pubServer.nextLine().then((line) {
       if (line.contains("successfully")) return;
 
       // This line wasn't it, so ignore it and keep trying.
       return nextLine();
     });
   }
 
   schedule(nextLine);
 }