Issue 24429002: Tighten DEPS rules further.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24429002: Tighten DEPS rules further. (Closed)

Created:
7 years, 3 months ago by Ben Goodger (Google)

Modified:
7 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, sadrul, ben+watch_chromium.org, Ian Vollick, tfarina, dcheng, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Tighten DEPS rules further. BUG=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225089

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : moar #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -20 lines)			Patch
M	ui/DEPS	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download
M	ui/android/DEPS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/app_list/DEPS	View	1	1 chunk	+8 lines, -3 lines	0 comments	Download
M	ui/aura/DEPS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/DEPS	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
A	ui/base/clipboard/DEPS	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	ui/base/dragdrop/DEPS	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A +	ui/base/l10n/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/compositor/DEPS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/gfx/DEPS	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
A +	ui/gfx/android/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gl/DEPS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A +	ui/gl/android/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/message_center/DEPS	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/native_theme/DEPS	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/oak/DEPS	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	ui/shell_dialogs/DEPS	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/snapshot/DEPS	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/surface/DEPS	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/views/DEPS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/webui/DEPS	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

7 years, 3 months ago (2013-09-24 22:25:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r225089 (presubmit successful).

Expand Messages | Collapse Messages