third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h - Issue 2442763002: Convert Dictionary handling to RTCConfiguration IDL dictionary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

Issue 2442763002: Convert Dictionary handling to RTCConfiguration IDL dictionary (Closed)

Patch Set: address hbos@'s feedback Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCIceServer.idl ('k') | third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

index 75c99b911bfa5df16015d213473137e6f59dea4b..19729d50eaa97e4f3175386134028d9275b959b7 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

@@ -32,7 +32,6 @@

#define RTCPeerConnection_h

#include "bindings/core/v8/ActiveScriptWrappable.h"

-#include "bindings/core/v8/Dictionary.h"

#include "bindings/core/v8/ScriptPromise.h"

#include "core/dom/ActiveDOMObject.h"

#include "modules/EventTargetModules.h"

@@ -49,6 +48,7 @@ namespace blink {

class ExceptionState;

class MediaStreamTrack;

class RTCAnswerOptions;

+class RTCConfiguration;

class RTCDTMFSender;

class RTCDataChannel;

class RTCIceCandidateInitOrRTCIceCandidate;

@@ -72,7 +72,7 @@ class RTCPeerConnection final : public EventTargetWithInlineData,

public:

static RTCPeerConnection* create(ExecutionContext*,

- const Dictionary&,

+ const RTCConfiguration&,

const Dictionary&,

ExceptionState&);

~RTCPeerConnection() override;

@@ -107,7 +107,8 @@ class RTCPeerConnection final : public EventTargetWithInlineData,

String signalingState() const;

- void updateIce(const Dictionary& rtcConfiguration,

+ void updateIce(ExecutionContext*,

+ const RTCConfiguration&,

const Dictionary& mediaConstraints,

ExceptionState&);