Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

Issue 2442763002: Convert Dictionary handling to RTCConfiguration IDL dictionary (Closed)
Patch Set: revert rtcpMuxPolicy default, also measure urls Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
index 757cb8d6d1be5ad0083caca7579104bcd6d2ff57..a48401eb421ac149382738e00326f3f409c0514a 100644
--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
@@ -63,9 +63,8 @@ enum RTCIceConnectionState {
[
ActiveScriptWrappable,
DependentLifetime,
- // TODO(guidou): There should only be one constructor argument, and it
- // should be optional.
- Constructor(Dictionary rtcConfiguration, optional Dictionary mediaConstraints),
+ // TODO(guidou): There should only be one constructor argument.
+ Constructor(optional RTCConfiguration configuration, optional Dictionary mediaConstraints),
ConstructorCallWith=ExecutionContext,
NoInterfaceObject,
RaisesException=Constructor,
@@ -122,7 +121,7 @@ enum RTCIceConnectionState {
[RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> generateCertificate(AlgorithmIdentifier keygenAlgorithm);
// Non-standard or removed from the spec:
- [Measure, RaisesException] void updateIce(optional Dictionary configuration, optional Dictionary mediaConstraints);
+ [Measure, CallWith=ExecutionContext, RaisesException] void updateIce(optional RTCConfiguration configuration, optional Dictionary mediaConstraints);
[Measure] sequence<MediaStream> getLocalStreams();
[Measure] sequence<MediaStream> getRemoteStreams();
[Measure] MediaStream getStreamById(DOMString streamId);

Powered by Google App Engine
This is Rietveld 408576698