Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

Issue 2442763002: Convert Dictionary handling to RTCConfiguration IDL dictionary (Closed)
Patch Set: address hbos@'s feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 }; 56 };
57 57
58 // https://w3c.github.io/webrtc-pc/#interface-definition 58 // https://w3c.github.io/webrtc-pc/#interface-definition
59 59
60 // TODO(guidou): Many types are of the wrong type in this interface: 60 // TODO(guidou): Many types are of the wrong type in this interface:
61 // * Dictionary -> specific dictionary types like RTCConfiguration 61 // * Dictionary -> specific dictionary types like RTCConfiguration
62 // * VoidCallback -> VoidFunction 62 // * VoidCallback -> VoidFunction
63 [ 63 [
64 ActiveScriptWrappable, 64 ActiveScriptWrappable,
65 DependentLifetime, 65 DependentLifetime,
66 // TODO(guidou): There should only be one constructor argument, and it 66 // TODO(guidou): There should only be one constructor argument.
67 // should be optional. 67 Constructor(optional RTCConfiguration configuration, optional Dictionary med iaConstraints),
68 Constructor(Dictionary rtcConfiguration, optional Dictionary mediaConstraint s),
69 ConstructorCallWith=ExecutionContext, 68 ConstructorCallWith=ExecutionContext,
70 NoInterfaceObject, 69 NoInterfaceObject,
71 RaisesException=Constructor, 70 RaisesException=Constructor,
72 ] interface RTCPeerConnection : EventTarget { 71 ] interface RTCPeerConnection : EventTarget {
73 [CallWith=ScriptState] Promise<RTCSessionDescription> createOffer(optional R TCOfferOptions options); 72 [CallWith=ScriptState] Promise<RTCSessionDescription> createOffer(optional R TCOfferOptions options);
74 [CallWith=ScriptState] Promise<RTCSessionDescription> createAnswer(optional RTCAnswerOptions options); 73 [CallWith=ScriptState] Promise<RTCSessionDescription> createAnswer(optional RTCAnswerOptions options);
75 [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescripti onInit description); 74 [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescripti onInit description);
76 readonly attribute RTCSessionDescription? localDescription; 75 readonly attribute RTCSessionDescription? localDescription;
77 // readonly attribute RTCSessionDescription? currentLocalDescription; 76 // readonly attribute RTCSessionDescription? currentLocalDescription;
78 // readonly attribute RTCSessionDescription? pendingLocalDescription; 77 // readonly attribute RTCSessionDescription? pendingLocalDescription;
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 // TODO(guidou): The label argument should have [TreatNullAs=EmptyString] 114 // TODO(guidou): The label argument should have [TreatNullAs=EmptyString]
116 // and be non-nullable. 115 // and be non-nullable.
117 [CallWith=ExecutionContext, RaisesException] RTCDataChannel createDataChanne l([TreatUndefinedAs=NullString] DOMString? label, optional Dictionary options); 116 [CallWith=ExecutionContext, RaisesException] RTCDataChannel createDataChanne l([TreatUndefinedAs=NullString] DOMString? label, optional Dictionary options);
118 attribute EventHandler ondatachannel; 117 attribute EventHandler ondatachannel;
119 118
120 // Certificate management 119 // Certificate management
121 // https://w3c.github.io/webrtc-pc/#sec.cert-mgmt 120 // https://w3c.github.io/webrtc-pc/#sec.cert-mgmt
122 [RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> gener ateCertificate(AlgorithmIdentifier keygenAlgorithm); 121 [RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> gener ateCertificate(AlgorithmIdentifier keygenAlgorithm);
123 122
124 // Non-standard or removed from the spec: 123 // Non-standard or removed from the spec:
125 [Measure, RaisesException] void updateIce(optional Dictionary configuration, optional Dictionary mediaConstraints); 124 [Measure, CallWith=ExecutionContext, RaisesException] void updateIce(optiona l RTCConfiguration configuration, optional Dictionary mediaConstraints);
126 [Measure] sequence<MediaStream> getLocalStreams(); 125 [Measure] sequence<MediaStream> getLocalStreams();
127 [Measure] sequence<MediaStream> getRemoteStreams(); 126 [Measure] sequence<MediaStream> getRemoteStreams();
128 [Measure] MediaStream getStreamById(DOMString streamId); 127 [Measure] MediaStream getStreamById(DOMString streamId);
129 [Measure, CallWith=ExecutionContext, RaisesException] void addStream(MediaSt ream? stream, optional Dictionary mediaConstraints); 128 [Measure, CallWith=ExecutionContext, RaisesException] void addStream(MediaSt ream? stream, optional Dictionary mediaConstraints);
130 [Measure, RaisesException] void removeStream(MediaStream? stream); 129 [Measure, RaisesException] void removeStream(MediaStream? stream);
131 [Measure, RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack t rack); 130 [Measure, RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack t rack);
132 attribute EventHandler onaddstream; 131 attribute EventHandler onaddstream;
133 attribute EventHandler onremovestream; 132 attribute EventHandler onremovestream;
134 }; 133 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698