Convert Dictionary handling to RTCConfiguration IDL dictionary

third_party/WebKit/Source/modules/peerconnection/RTCConfiguration.idl

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// https://w3c.github.io/webrtc-pc/#rtcicetransportpolicy-enum
+

[hbos_chromium, 2016/10/24 11:35:24]

nit: Here and other places - do we have a space between the link and the
enum/dictionary in other files? I would remove it here and other places in this
file, but up to you.

[foolip, 2016/10/24 12:05:25]

In core/ there's pretty consistently a blank line after the spec link, and in
modules/peerconnection/ there's a bit of both. I've always had the blank line
because often a single spec link is for several of the typedefs, enums and the
dictionary/interface that follows.

+// TODO(foolip): This is called RTCIceTransportPolicy in the spec, and that enum
+// does not have "none" as one of its values.
+enum RTCIceTransports {
+    "none",
+    "relay",
+    "all"
+};
+
+// https://w3c.github.io/webrtc-pc/#rtcbundlepolicy-enum
+
+enum RTCBundlePolicy {
+    "balanced",
+    "max-compat",
+    "max-bundle"
+};
+
+// https://w3c.github.io/webrtc-pc/#rtcrtcpmuxpolicy-enum
+
+enum RTCRtcpMuxPolicy {
+    "negotiate",
+    "require"
+};
+
+// https://w3c.github.io/webrtc-pc/#rtcconfiguration-dictionary
+
+dictionary RTCConfiguration {
+    sequence<RTCIceServer> iceServers;
+    // TODO(foolip): |iceTransports| should be |iceTransportPolicy|.

[foolip, 2016/10/23 10:17:58]

Having written https://github.com/w3c/web-platform-tests/pull/4062 and tested
Firefox, I think this is pretty serious, requiring { iceTransports: "relay",
iceTransportPolicy: "relay" } to work on both Chrome and Firefox. I'd like to
minimize observable changes in this CL for bisect-ability, but I think that's
worth fixing before shipping unprefixed RTCPeerConnection, by looking first at
iceTransportPolicy, and falling back to iceTransports with use counter.

+    RTCIceTransports iceTransports = "all";
+    RTCBundlePolicy bundlePolicy = "balanced";
+    // TODO(foolip): |rtcpMuxPolicy| default should be "require".
+    RTCRtcpMuxPolicy rtcpMuxPolicy;
+    // TODO(foolip): DOMString peerIdentity;
+    // TODO(foolip): |certificates| should not be nullable.
+    sequence<RTCCertificate>? certificates;
+    // TODO(foolip): unsigned short iceCandidatePoolSize = 0;
+};