Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 CONSOLE WARNING: line 1: Unknown constraint named invalid rejected | 1 CONSOLE WARNING: line 1: Unknown constraint named invalid rejected |
| 2 CONSOLE WARNING: line 1: Unknown constraint named valid_but_unsupported_1 reject ed | 2 CONSOLE WARNING: line 1: Unknown constraint named valid_but_unsupported_1 reject ed |
| 3 CONSOLE WARNING: line 1: Unknown constraint named valid_but_unsupported_1 reject ed | 3 CONSOLE WARNING: line 1: Unknown constraint named valid_but_unsupported_1 reject ed |
| 4 Tests the RTCPeerConnection constructor. | 4 Tests the RTCPeerConnection constructor. |
| 5 | 5 |
| 6 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ". | 6 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ". |
| 7 | 7 |
| 8 | 8 |
| 9 PASS new webkitRTCPeerConnection(null); did not throw exception. | 9 PASS new webkitRTCPeerConnection(null); did not throw exception. |
| 10 PASS new webkitRTCPeerConnection(undefined); did not throw exception. | 10 PASS new webkitRTCPeerConnection(undefined); did not throw exception. |
| 11 PASS new webkitRTCPeerConnection(); threw exception TypeError: Failed to constru ct 'RTCPeerConnection': 1 argument required, but only 0 present.. | 11 PASS new webkitRTCPeerConnection({}); did not throw exception. |
| 12 PASS new webkitRTCPeerConnection(''); threw exception TypeError: Failed to const ruct 'RTCPeerConnection': parameter 1 ('rtcConfiguration') is not an object.. | 12 PASS new webkitRTCPeerConnection(); did not throw exception. |
| 13 PASS new webkitRTCPeerConnection(''); threw exception TypeError: Failed to const ruct 'RTCPeerConnection': parameter 1 ('configuration') is not an object.. | |
| 13 PASS new webkitRTCPeerConnection({iceServers:[]}); did not throw exception. | 14 PASS new webkitRTCPeerConnection({iceServers:[]}); did not throw exception. |
| 14 PASS new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com'}]}); did not t hrow exception. | 15 PASS new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com'}]}); did not t hrow exception. |
| 15 PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x '}]}); did not throw exception. | 16 PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x '}]}); did not throw exception. |
| 16 PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x '},{url:'stun:bar.com'}]}); did not throw exception. | 17 PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x '},{url:'stun:bar.com'}]}); did not throw exception. |
| 17 PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}); did not throw exception. | 18 PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}); did not throw exception. |
| 18 PASS new webkitRTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'turn:foo.c om']}]}); did not throw exception. | 19 PASS new webkitRTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'turn:foo.c om']}]}); did not throw exception. |
| 19 PASS new webkitRTCPeerConnection({fooServers:[]}); threw exception TypeError: Fa iled to construct 'RTCPeerConnection': Malformed RTCConfiguration. | 20 PASS new webkitRTCPeerConnection({fooServers:[]}); did not throw exception. |
| 20 PASS new webkitRTCPeerConnection({iceServers:true}); threw exception TypeError: Failed to construct 'RTCPeerConnection': Malformed RTCConfiguration. | 21 PASS new webkitRTCPeerConnection({iceServers:true}); threw exception TypeError: Failed to construct 'RTCPeerConnection': The value provided is neither an array, nor does it have indexed properties.. |
| 21 PASS new webkitRTCPeerConnection({iceServers:[1, 2, 3]}); threw exception TypeEr ror: Failed to construct 'RTCPeerConnection': Malformed RTCIceServer. | 22 PASS new webkitRTCPeerConnection({iceServers:[1, 2, 3]}); threw exception TypeEr ror: Failed to construct 'RTCPeerConnection': cannot convert to dictionary.. |
|
Guido Urdaneta
2016/10/24 08:56:27
nit: extra period intended? you can leave it if yo
foolip
2016/10/24 09:17:36
These are from the test harness, the exception mes
| |
| 22 PASS new webkitRTCPeerConnection({iceServers:[{}]}); threw exception TypeError: Failed to construct 'RTCPeerConnection': Malformed RTCIceServer. | 23 PASS new webkitRTCPeerConnection({iceServers:[{}]}); threw exception TypeError: Failed to construct 'RTCPeerConnection': Malformed RTCIceServer. |
| 23 PASS new webkitRTCPeerConnection({iceServers:[{url:'foo'}]}); threw exception Ty peError: Failed to construct 'RTCPeerConnection': Malformed URL. | 24 PASS new webkitRTCPeerConnection({iceServers:[{url:'foo'}]}); threw exception Ty peError: Failed to construct 'RTCPeerConnection': Malformed URL. |
| 24 PASS new webkitRTCPeerConnection({iceServers:[{urls:[1, 'turn:foo.com']}]}); thr ew exception TypeError: Failed to construct 'RTCPeerConnection': Malformed URL. | 25 PASS new webkitRTCPeerConnection({iceServers:[{urls:[1, 'turn:foo.com']}]}); thr ew exception TypeError: Failed to construct 'RTCPeerConnection': Malformed URL. |
| 25 PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'none'}); did not throw exception. | 26 PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'none'}); did not throw exception. |
| 26 PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'relay'}); did no t throw exception. | 27 PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'relay'}); did no t throw exception. |
| 27 PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'all'}); did not throw exception. | 28 PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'all'}); did not throw exception. |
| 28 PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'foo'}); threw ex ception TypeError: Failed to construct 'RTCPeerConnection': Malformed RTCIceTran sports. | 29 PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'foo'}); threw ex ception TypeError: Failed to construct 'RTCPeerConnection': The provided value ' foo' is not a valid enum value of type RTCIceTransports.. |
|
Guido Urdaneta
2016/10/24 08:56:27
nit: ditto
| |
| 29 PASS new webkitRTCPeerConnection({iceServers:[], bundlePolicy:'balanced'}); did not throw exception. | 30 PASS new webkitRTCPeerConnection({iceServers:[], bundlePolicy:'balanced'}); did not throw exception. |
| 30 PASS new webkitRTCPeerConnection({iceServers:[], bundlePolicy:'max-bundle'}); di d not throw exception. | 31 PASS new webkitRTCPeerConnection({iceServers:[], bundlePolicy:'max-bundle'}); di d not throw exception. |
| 31 PASS new webkitRTCPeerConnection({iceServers:[], bundlePolicy:'max-compat'}); di d not throw exception. | 32 PASS new webkitRTCPeerConnection({iceServers:[], bundlePolicy:'max-compat'}); di d not throw exception. |
| 32 PASS new webkitRTCPeerConnection({iceServers:[], bundlePolicy:'foo'}); threw exc eption TypeError: Failed to construct 'RTCPeerConnection': Malformed RTCBundlePo licy. | 33 PASS new webkitRTCPeerConnection({iceServers:[], bundlePolicy:'foo'}); threw exc eption TypeError: Failed to construct 'RTCPeerConnection': The provided value 'f oo' is not a valid enum value of type RTCBundlePolicy.. |
|
Guido Urdaneta
2016/10/24 08:56:27
nit: ditto
| |
| 33 PASS new webkitRTCPeerConnection({iceServers:[], rtcpMuxPolicy:'negotiate'}); di d not throw exception. | 34 PASS new webkitRTCPeerConnection({iceServers:[], rtcpMuxPolicy:'negotiate'}); di d not throw exception. |
| 34 PASS new webkitRTCPeerConnection({iceServers:[], rtcpMuxPolicy:'require'}); did not throw exception. | 35 PASS new webkitRTCPeerConnection({iceServers:[], rtcpMuxPolicy:'require'}); did not throw exception. |
| 35 PASS new webkitRTCPeerConnection({iceServers:[], rtcpMuxPolicy:'foo'}); threw ex ception TypeError: Failed to construct 'RTCPeerConnection': Malformed RTCRtcpMux Policy. | 36 PASS new webkitRTCPeerConnection({iceServers:[], rtcpMuxPolicy:'foo'}); threw ex ception TypeError: Failed to construct 'RTCPeerConnection': The provided value ' foo' is not a valid enum value of type RTCRtcpMuxPolicy.. |
|
Guido Urdaneta
2016/10/24 08:56:27
nit: ditto
| |
| 36 PASS new webkitRTCPeerConnection(null, {mandatory:{valid_and_supported_1:1}}); d id not throw exception. | 37 PASS new webkitRTCPeerConnection(null, {mandatory:{valid_and_supported_1:1}}); d id not throw exception. |
| 37 PASS new webkitRTCPeerConnection(null, {mandatory:{valid_and_supported_1:1, vali d_and_supported_2:1}}); did not throw exception. | 38 PASS new webkitRTCPeerConnection(null, {mandatory:{valid_and_supported_1:1, vali d_and_supported_2:1}}); did not throw exception. |
| 38 PASS new webkitRTCPeerConnection(null, {optional:[{valid_and_supported_1:0}]}); did not throw exception. | 39 PASS new webkitRTCPeerConnection(null, {optional:[{valid_and_supported_1:0}]}); did not throw exception. |
| 39 PASS new webkitRTCPeerConnection(null, {optional:[{valid_and_supported_1:0},{val id_and_supported_2:0}]}); did not throw exception. | 40 PASS new webkitRTCPeerConnection(null, {optional:[{valid_and_supported_1:0},{val id_and_supported_2:0}]}); did not throw exception. |
| 40 PASS new webkitRTCPeerConnection(null, {optional:[{valid_but_unsupported_1:0},{v alid_but_unsupported_2:0}]}); did not throw exception. | 41 PASS new webkitRTCPeerConnection(null, {optional:[{valid_but_unsupported_1:0},{v alid_but_unsupported_2:0}]}); did not throw exception. |
| 41 PASS new webkitRTCPeerConnection(null, {mandatory:{valid_and_supported_1:66}}); threw exception NotSupportedError: Failed to construct 'RTCPeerConnection': Unsa tisfiable constraint valid_and_supported_1. | 42 PASS new webkitRTCPeerConnection(null, {mandatory:{valid_and_supported_1:66}}); threw exception NotSupportedError: Failed to construct 'RTCPeerConnection': Unsa tisfiable constraint valid_and_supported_1. |
| 42 PASS new webkitRTCPeerConnection(null, {mandatory:{invalid:1}}); threw exception NotSupportedError: Failed to construct 'RTCPeerConnection': Unsatisfiable const raint invalid. | 43 PASS new webkitRTCPeerConnection(null, {mandatory:{invalid:1}}); threw exception NotSupportedError: Failed to construct 'RTCPeerConnection': Unsatisfiable const raint invalid. |
| 43 PASS new webkitRTCPeerConnection(null, {mandatory:{valid_but_unsupported_1:1}}); threw exception NotSupportedError: Failed to construct 'RTCPeerConnection': Uns atisfiable constraint valid_but_unsupported_1. | 44 PASS new webkitRTCPeerConnection(null, {mandatory:{valid_but_unsupported_1:1}}); threw exception NotSupportedError: Failed to construct 'RTCPeerConnection': Uns atisfiable constraint valid_but_unsupported_1. |
| 44 PASS new webkitRTCPeerConnection(null, {mandatory:{valid_but_unsupported_1:1, va lid_and_supported_1:1}}); threw exception NotSupportedError: Failed to construct 'RTCPeerConnection': Unsatisfiable constraint valid_but_unsupported_1. | 45 PASS new webkitRTCPeerConnection(null, {mandatory:{valid_but_unsupported_1:1, va lid_and_supported_1:1}}); threw exception NotSupportedError: Failed to construct 'RTCPeerConnection': Unsatisfiable constraint valid_but_unsupported_1. |
| 45 PASS new webkitRTCPeerConnection(null, {optional:{valid_and_supported_1:0}}); th rew exception TypeError: Failed to construct 'RTCPeerConnection': Malformed cons traints object.. | 46 PASS new webkitRTCPeerConnection(null, {optional:{valid_and_supported_1:0}}); th rew exception TypeError: Failed to construct 'RTCPeerConnection': Malformed cons traints object.. |
| 46 PASS new webkitRTCPeerConnection(null, {optional:[{valid_and_supported_1:0,valid _and_supported_2:0}]}); threw exception TypeError: Failed to construct 'RTCPeerC onnection': Malformed constraints object.. | 47 PASS new webkitRTCPeerConnection(null, {optional:[{valid_and_supported_1:0,valid _and_supported_2:0}]}); threw exception TypeError: Failed to construct 'RTCPeerC onnection': Malformed constraints object.. |
| 47 PASS new webkitRTCPeerConnection(null, {optional:[{invalid:0}]}); did not throw exception. | 48 PASS new webkitRTCPeerConnection(null, {optional:[{invalid:0}]}); did not throw exception. |
| 48 PASS new webkitRTCPeerConnection(null, {valid_and_supported_1:1}); threw excepti on TypeError: Failed to construct 'RTCPeerConnection': Malformed constraints obj ect.. | 49 PASS new webkitRTCPeerConnection(null, {valid_and_supported_1:1}); threw excepti on TypeError: Failed to construct 'RTCPeerConnection': Malformed constraints obj ect.. |
| 49 PASS new webkitRTCPeerConnection(null, {valid_but_unsupported_1:1}); threw excep tion TypeError: Failed to construct 'RTCPeerConnection': Malformed constraints o bject.. | 50 PASS new webkitRTCPeerConnection(null, {valid_but_unsupported_1:1}); threw excep tion TypeError: Failed to construct 'RTCPeerConnection': Malformed constraints o bject.. |
| 50 PASS new webkitRTCPeerConnection(null, {valid_and_supported_2:1, mandatory:{vali d_and_supported_1:1}}); threw exception TypeError: Failed to construct 'RTCPeerC onnection': Malformed constraints object.. | 51 PASS new webkitRTCPeerConnection(null, {valid_and_supported_2:1, mandatory:{vali d_and_supported_1:1}}); threw exception TypeError: Failed to construct 'RTCPeerC onnection': Malformed constraints object.. |
| 51 PASS new webkitRTCPeerConnection({iceServers:[], certificates:null}); did not th row exception. | 52 PASS new webkitRTCPeerConnection({iceServers:[], certificates:null}); did not th row exception. |
| 53 PASS new webkitRTCPeerConnection({iceServers:[], certificates:undefined}); did n ot throw exception. | |
| 52 PASS new webkitRTCPeerConnection({iceServers:[], certificates:[]}); did not thro w exception. | 54 PASS new webkitRTCPeerConnection({iceServers:[], certificates:[]}); did not thro w exception. |
| 53 PASS new webkitRTCPeerConnection({iceServers:[], certificates:[null]}); threw ex ception TypeError: Failed to construct 'RTCPeerConnection': Malformed sequence<R TCCertificate>. | 55 PASS new webkitRTCPeerConnection({iceServers:[], certificates:[null]}); threw ex ception TypeError: Failed to construct 'RTCPeerConnection': Invalid Array elemen t type. |
| 54 PASS new webkitRTCPeerConnection({iceServers:[], certificates:[1337]}); threw ex ception TypeError: Failed to construct 'RTCPeerConnection': Malformed sequence<R TCCertificate>. | 56 PASS new webkitRTCPeerConnection({iceServers:[], certificates:[1337]}); threw ex ception TypeError: Failed to construct 'RTCPeerConnection': Invalid Array elemen t type. |
| 55 PASS new webkitRTCPeerConnection({iceServers:[], certificates:[certRSA]}, null); did not throw exception. | 57 PASS new webkitRTCPeerConnection({iceServers:[], certificates:[certRSA]}, null); did not throw exception. |
| 56 PASS new webkitRTCPeerConnection({iceServers:[], certificates:[certECDSA]}, null ); did not throw exception. | 58 PASS new webkitRTCPeerConnection({iceServers:[], certificates:[certECDSA]}, null ); did not throw exception. |
| 57 PASS certExpired.expires <= new Date().getTime() is true | 59 PASS certExpired.expires <= new Date().getTime() is true |
| 58 PASS new webkitRTCPeerConnection({iceServers:[], certificates:[certExpired]}, nu ll); threw exception InvalidStateError: Failed to construct 'RTCPeerConnection': Expired certificate(s).. | 60 PASS new webkitRTCPeerConnection({iceServers:[], certificates:[certExpired]}, nu ll); threw exception InvalidStateError: Failed to construct 'RTCPeerConnection': Expired certificate(s).. |
| 59 PASS successfullyParsed is true | 61 PASS successfullyParsed is true |
| 60 | 62 |
| 61 TEST COMPLETE | 63 TEST COMPLETE |
| 62 | 64 |
| OLD | NEW |