third_party/WebKit/Source/modules/peerconnection/RTCIceServer.idl - Issue 2442763002: Convert Dictionary handling to RTCConfiguration IDL dictionary

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCIceServer.idl

Issue 2442763002: Convert Dictionary handling to RTCConfiguration IDL dictionary (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCConfiguration.idl ('k') | third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/webrtc-pc/#rtciceserver-dictionary

	6

	7 dictionary RTCIceServer {

	8 // TODO(foolip): \|urls\| should be required and \|url\| is not in the spec.

	9 (DOMString or sequence<DOMString>) urls;

	10 DOMString url;

	11 DOMString username;

	12 DOMString credential;

	13 // TODO(foolip): RTCIceCredentialType credentialType = "password";
	hta - Chromium 2016/10/23 07:03:49 Any reason not to add this now? Any reason not to add this now? foolip 2016/10/23 08:58:56 The question is what one would do with the "token" Show quoted text On 2016/10/23 07:03:49, hta - Chromium wrote: > Any reason not to add this now? The question is what one would do with the "token" value, is that trivial to support? hta - Chromium 2016/10/23 16:39:02 The correct handling given current support should Show quoted text On 2016/10/23 08:58:56, foolip wrote: > On 2016/10/23 07:03:49, hta - Chromium wrote: > > Any reason not to add this now? > > The question is what one would do with the "token" value, is that trivial to > support? The correct handling given current support should be checking that the token is "password", and taking the action prescribed in the spec for unknown values if it's anything else. foolip 2016/10/23 20:56:51 Turns out that Gecko has credentialType in the dic Show quoted text On 2016/10/23 16:39:02, hta - Chromium wrote: > On 2016/10/23 08:58:56, foolip wrote: > > On 2016/10/23 07:03:49, hta - Chromium wrote: > > > Any reason not to add this now? > > > > The question is what one would do with the "token" value, is that trivial to > > support? > > The correct handling given current support should be checking that the token is > "password", and taking the action prescribed in the spec for unknown values if > it's anything else. Turns out that Gecko has credentialType in the dictionary, but `new RTCPeerConnection({ iceServers: [{ urls: "turn:turn.example.net", username: "user", credential: "cred", credentialType: "token" }] })` logs "RTCConfiguration TURN credentialType "token" is not yet implemented. Treating as password. https://bugzil.la/1247616" in the console. I don't think doing that is a good idea, there's then no way to later feature detect when it's actually supported. Another way would be to have "password" as the only RTCIceCredentialType enum entry, throwing TypeError for "token". Not sure, an enum with just one value seems kind of pointless. WDYT?
	14 };

OLD	NEW