chrome/browser/resources/print_preview/settings/copies_settings.css - Issue 2442743003: Fix 2 pixel flicker from collate box

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/print_preview/settings/copies_settings.css

Issue 2442743003: Fix 2 pixel flicker from collate box (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 * Use of this source code is governed by a BSD-style license that can be	2 * Use of this source code is governed by a BSD-style license that can be

3 * found in the LICENSE file. */	3 * found in the LICENSE file. */

4	4

5 #copies-settings .collate-container {	5 #copies-settings .collate-container {

6 -webkit-padding-start: 16px;	6 -webkit-padding-start: 16px;

7 display: inline-block;	7 display: inline-block;

8 }	8 }

9	9

10 #copies-settings .collate-container label {	10 #copies-settings .collate-container label {

11 padding-top: 6px;	11 padding-top: 4px;
	dpapad 2016/10/21 22:31:35 It is a bit fragile to use padding for centering a It is a bit fragile to use padding for centering an item within a row. Can you try the following which is more robust, and I think achieves the exact same visual behavior? Effectively it removes padding completely, and lets the label be centered by other existing rules (vertical-align: baseline). #copies-settings .collate-container label { padding: 0; } rbpotter 2016/10/21 23:00:38 Yes, this has the same behavior. Thanks! Show quoted text On 2016/10/21 22:31:35, dpapad wrote: > It is a bit fragile to use padding for centering an item within a row. Can you > try the following which is more robust, and I think achieves the exact same > visual behavior? Effectively it removes padding completely, and lets the label > be centered by other existing rules (vertical-align: baseline). > > #copies-settings .collate-container label { > padding: 0; > } Yes, this has the same behavior. Thanks!
12 }	12 }

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »