Fix 2 pixel flicker from collate box

Fix 2 pixel flicker from collate box

Modifies padding on top of collate box so that it does not cause a
flicker when it appears next to the new copies input field.

BUG=658400
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/354fdaa367130497882b1c1421ba30882d19ca00
Cr-Commit-Position: refs/heads/master@{#426983}

[rbpotter, 2016-10-21 20:57:19]

Description was changed from

==========
Fix 2 pixel flicker from collate box

Modifies padding on top of collate box so that it does not cause a
flicker when it appears next to the new copies input field.

BUG=658400
==========

to

==========
Fix 2 pixel flicker from collate box

Modifies padding on top of collate box so that it does not cause a
flicker when it appears next to the new copies input field.

BUG=658400
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[rbpotter, 2016-10-21 20:57:34]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[rbpotter, 2016-10-21 20:58:02]

Description was changed from

==========
Fix 2 pixel flicker from collate box

Modifies padding on top of collate box so that it does not cause a
flicker when it appears next to the new copies input field.

BUG=658400
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix 2 pixel flicker from collate box

Modifies padding on top of collate box so that it does not cause a
flicker when it appears next to the new copies input field.

BUG=658400
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[rbpotter, 2016-10-21 20:58:02]

rbpotter@chromium.org changed reviewers:
+ dpapad@chromium.org

[commit-bot: I haz the power, 2016-10-21 20:58:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-10-21 22:31:35]

https://codereview.chromium.org/2442743003/diff/1/chrome/browser/resources/pr...
File chrome/browser/resources/print_preview/settings/copies_settings.css
(right):

https://codereview.chromium.org/2442743003/diff/1/chrome/browser/resources/pr...
chrome/browser/resources/print_preview/settings/copies_settings.css:11:
padding-top: 4px;
It is a bit fragile to use padding for centering an item within a row. Can you
try the following which is more robust, and I think achieves the exact same
visual behavior? Effectively it removes padding completely, and lets the label
be centered by other existing rules (vertical-align: baseline).

#copies-settings .collate-container label {
  padding: 0;
}

[rbpotter, 2016-10-21 22:47:57]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 22:48:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2016-10-21 23:00:38]

https://codereview.chromium.org/2442743003/diff/1/chrome/browser/resources/pr...
File chrome/browser/resources/print_preview/settings/copies_settings.css
(right):

https://codereview.chromium.org/2442743003/diff/1/chrome/browser/resources/pr...
chrome/browser/resources/print_preview/settings/copies_settings.css:11:
padding-top: 4px;
On 2016/10/21 22:31:35, dpapad wrote:
> It is a bit fragile to use padding for centering an item within a row. Can you
> try the following which is more robust, and I think achieves the exact same
> visual behavior? Effectively it removes padding completely, and lets the label
> be centered by other existing rules (vertical-align: baseline).
> 
> #copies-settings .collate-container label {
>   padding: 0;
> }

Yes, this has the same behavior. Thanks!

[dpapad, 2016-10-21 23:06:29]

lgtm

[commit-bot: I haz the power, 2016-10-22 03:33:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 03:33:56]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[rbpotter, 2016-10-22 04:54:11]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-22 04:54:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 05:39:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 05:39:44]

Dry run: This issue passed the CQ dry run.

[rbpotter, 2016-10-22 05:59:27]

The CQ bit was checked by rbpotter@chromium.org

[commit-bot: I haz the power, 2016-10-22 05:59:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 06:11:13]

Description was changed from

==========
Fix 2 pixel flicker from collate box

Modifies padding on top of collate box so that it does not cause a
flicker when it appears next to the new copies input field.

BUG=658400
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix 2 pixel flicker from collate box

Modifies padding on top of collate box so that it does not cause a
flicker when it appears next to the new copies input field.

BUG=658400
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-22 06:11:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-22 06:13:19]

Description was changed from

==========
Fix 2 pixel flicker from collate box

Modifies padding on top of collate box so that it does not cause a
flicker when it appears next to the new copies input field.

BUG=658400
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix 2 pixel flicker from collate box

Modifies padding on top of collate box so that it does not cause a
flicker when it appears next to the new copies input field.

BUG=658400
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/354fdaa367130497882b1c1421ba30882d19ca00
Cr-Commit-Position: refs/heads/master@{#426983}
==========

[commit-bot: I haz the power, 2016-10-22 06:13:20]

Patchset 2 (id:??) landed as
https://crrev.com/354fdaa367130497882b1c1421ba30882d19ca00
Cr-Commit-Position: refs/heads/master@{#426983}