Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: scripts/slave/chromium/archive_layout_test_retry_summary.py

Issue 2442693003: Upload retry summary to desired location instead of uploading then moving. (Closed)
Patch Set: Change slave_utils.GSUtilCopyFile to take an optional dest filename. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/slave_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/chromium/archive_layout_test_retry_summary.py
diff --git a/scripts/slave/chromium/archive_layout_test_retry_summary.py b/scripts/slave/chromium/archive_layout_test_retry_summary.py
index f945784cddb2620d091a91d1077a1d0d8c24c335..befe0fd2dac13becfaff29795f9fa881bbe73c5c 100755
--- a/scripts/slave/chromium/archive_layout_test_retry_summary.py
+++ b/scripts/slave/chromium/archive_layout_test_retry_summary.py
@@ -4,17 +4,19 @@
# found in the LICENSE file.
"""This script is intended to archive retry summary results from
-try bot retries for layout tests along with layout test results.
+try bot retries of layout tests.
-The purpose if this is so that these retry results can be fetched
-from the same place that the first run results are fetched.
+By keeping these retry summary results in the same place as the
+layout test results from the first try (with patch), the retry
+results can be easily fetched from the same location as the results.
"""
-import logging
import argparse
+import logging
import os
import re
import socket
+import shutil
import sys
from slave import slave_utils
@@ -27,11 +29,9 @@ def ArchiveRetrySummary(args):
print 'Host name: %s' % socket.gethostname()
gs_base = '/'.join([args.gs_bucket, args.builder_name, args.build_number])
- slave_utils.GSUtilCopyFile(args.retry_summary_json,
- gs_base,
- cache_control="public, max-age=31556926")
- slave_utils.GSUtilMoveFile(os.path.join(gs_base, args.retry_summary_json),
- os.path.join(gs_base, 'retry_summary.json'))
+ slave_utils.GSUtilCopyFile(args.retry_summary_json, gs_base,
+ cache_control='public, max-age=31556926',
+ dest_filename='retry_summary.json')
return 0
« no previous file with comments | « no previous file | scripts/slave/slave_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698