Add ResumeRenderer to RendererScheduler for Purge+Suspend.

Add ResumeRenderer to RendererScheduler for Purge+Suspend.

- To avoid breaking web, we need to resume a backgrounded renderer that
  was purged and suspended.
- intent-to-implement-and-ship of background renderer's purge + suspend
  is
   https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
- one of the documents attached in the above intent is
  https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJvI/edit?usp=sharing
- The feature is not enabled by default because
  purge-and-suspend-time is 0.

BUG=635419
Committed: https://crrev.com/c51591267f94eb168c842bc3a7da44ad81aac84f
Cr-Commit-Position: refs/heads/master@{#427606}

[tasak, 2016-10-21 05:33:17]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 05:33:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 05:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 05:55:20]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tasak, 2016-10-21 06:11:12]

Patchset #1 (id:1) has been deleted

[tasak, 2016-10-21 06:11:33]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 06:11:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tasak, 2016-10-21 07:13:29]

tasak@google.com changed reviewers:
+ haraken@chromium.org, skyostil@chromium.org

[tasak, 2016-10-21 07:13:30]

Would you review this CL?

I created this patch by splitting the patch uploaded in
https://codereview.chromium.org/2387603003/.

[commit-bot: I haz the power, 2016-10-21 07:41:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 07:41:43]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-10-21 08:01:30]

LGTM

[Sami, 2016-10-24 17:19:45]

https://codereview.chromium.org/2442663002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/scheduler/renderer/renderer_scheduler.h
(right):

https://codereview.chromium.org/2442663002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/renderer/renderer_scheduler.h:137:
// automatically suspended again if continuously backgrounded.
This re-suspension logic is not a part of this patch, right? Also is it
something RendererScheduler is going to do automatically, or will we rely on
someone else calling SuspendRenderer again at an appropriate time?

If the RendererScheduler is going to control that automatically, then I think
ResumeRenderer should be called something like ResumeRendererTemporarily() to
make it clear that re-suspension will happen eventually.

[tasak, 2016-10-25 03:10:58]

Thank you for review.

https://codereview.chromium.org/2442663002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/scheduler/renderer/renderer_scheduler.h
(right):

https://codereview.chromium.org/2442663002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/renderer/renderer_scheduler.h:137:
// automatically suspended again if continuously backgrounded.
On 2016/10/24 17:19:45, Sami wrote:
> This re-suspension logic is not a part of this patch, right? Also is it
> something RendererScheduler is going to do automatically, or will we rely on
> someone else calling SuspendRenderer again at an appropriate time?
> 
> If the RendererScheduler is going to control that automatically, then I think
> ResumeRenderer should be called something like ResumeRendererTemporarily() to
> make it clear that re-suspension will happen eventually.

Yeah, not a part of this patch.
I modified the comment, i.e. TabManager / MemoryCoordinator will suspend the
renderer.

[tasak, 2016-10-25 03:11:12]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 03:11:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 04:49:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 04:49:17]

Dry run: This issue passed the CQ dry run.

[Sami, 2016-10-25 10:57:40]

lgtm.

[tasak, 2016-10-26 03:00:25]

The CQ bit was checked by tasak@google.com

[tasak, 2016-10-26 03:00:26]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2442663002/#ps40001
(title: "Fixed comment.")

[commit-bot: I haz the power, 2016-10-26 03:00:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:05:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:05:39]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[tasak, 2016-10-26 04:09:22]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2016-10-26 04:09:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:22:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:22:56]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[tasak, 2016-10-26 04:41:19]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2016-10-26 04:41:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 06:09:31]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-26 06:12:42]

Description was changed from

==========
Add ResumeRenderer to RendererScheduler for Purge+Suspend.

- To avoid breaking web, we need to resume a backgrounded renderer that
  was purged and suspended.
- intent-to-implement-and-ship of background renderer's purge + suspend
  is
   https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
- one of the documents attached in the above intent is
 
https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
- The feature is not enabled by default because
  purge-and-suspend-time is 0.

BUG=635419
==========

to

==========
Add ResumeRenderer to RendererScheduler for Purge+Suspend.

- To avoid breaking web, we need to resume a backgrounded renderer that
  was purged and suspended.
- intent-to-implement-and-ship of background renderer's purge + suspend
  is
   https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
- one of the documents attached in the above intent is
 
https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
- The feature is not enabled by default because
  purge-and-suspend-time is 0.

BUG=635419

Committed: https://crrev.com/c51591267f94eb168c842bc3a7da44ad81aac84f
Cr-Commit-Position: refs/heads/master@{#427606}
==========

[commit-bot: I haz the power, 2016-10-26 06:12:43]

Patchset 2 (id:??) landed as
https://crrev.com/c51591267f94eb168c842bc3a7da44ad81aac84f
Cr-Commit-Position: refs/heads/master@{#427606}