Invalidate the text edit handler on selection events

chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Handles automation from a desktop automation node.
  */
 
 goog.provide('DesktopAutomationHandler');
 
@@ skipping 410 matching lines @@
   onScrollPositionChanged: function(evt) {
     var currentRange = ChromeVoxState.instance.currentRange;
     if (currentRange && currentRange.isValid() && this.shouldOutput_(evt))
       new Output().withLocation(currentRange, null, evt.type).go();
   },
 
   /**
    * @param {!AutomationEvent} evt
    */
   onSelection: function(evt) {
+    // Invalidate any previous editable text handler state.

[dmazzoni, 2016/10/21 20:13:05]

Could you comment that this is because we get selection
events on menus, but the menu doesn't have focus?

I'd like to eventually fix this so that from the
perspective of accessibility, menu items really do
get focus.

[David Tseng, 2016/10/24 16:35:31]

Done.

+    this.textEditHandler_ = null;
+
     chrome.automation.getFocus(function(focus) {
       // Desktop tabs get "selection" when there's a focused webview during tab
       // switching.
       if (focus.role == RoleType.webView && evt.target.role == RoleType.tab) {
         ChromeVoxState.instance.setCurrentRange(
             cursors.Range.fromNode(focus.firstChild));
         return;
       }
 
       // Some cases (e.g. in overview mode), require overriding the assumption
@@ skipping 67 matching lines @@
 DesktopAutomationHandler.init_ = function() {
   chrome.automation.getDesktop(function(desktop) {
     ChromeVoxState.desktopAutomationHandler =
         new DesktopAutomationHandler(desktop);
   });
 };
 
 DesktopAutomationHandler.init_();
 
 });  // goog.scope