Invalidate the text edit handler on selection events

Invalidate the text edit handler on selection events

This is necessary to make braille output work in menus. If a text edit handler is active, output gets delegated through that handler, skipping the output o f the current range.

BUG=657036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4b5321f2888313442c6caf986a389a143920244c
Cr-Commit-Position: refs/heads/master@{#427107}

[David Tseng, 2016-10-20 22:11:54]

Description was changed from

==========
Invalidate the text edit handler on selection events

This is necessary to make braille output work in menus. If a text edit handler
is active, output gets delegated through that handler, skipping the output o f
the current range.

BUG=
==========

to

==========
Invalidate the text edit handler on selection events

This is necessary to make braille output work in menus. If a text edit handler
is active, output gets delegated through that handler, skipping the output o f
the current range.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-20 22:12:47]

Description was changed from

==========
Invalidate the text edit handler on selection events

This is necessary to make braille output work in menus. If a text edit handler
is active, output gets delegated through that handler, skipping the output o f
the current range.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Invalidate the text edit handler on selection events

This is necessary to make braille output work in menus. If a text edit handler
is active, output gets delegated through that handler, skipping the output o f
the current range.

BUG=657036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-20 22:12:47]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-10-21 20:13:06]

lgtm

https://codereview.chromium.org/2442583002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
(right):

https://codereview.chromium.org/2442583002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js:431:
// Invalidate any previous editable text handler state.
Could you comment that this is because we get selection
events on menus, but the menu doesn't have focus?

I'd like to eventually fix this so that from the
perspective of accessibility, menu items really do
get focus.

[David Tseng, 2016-10-24 16:35:31]

https://codereview.chromium.org/2442583002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
(right):

https://codereview.chromium.org/2442583002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js:431:
// Invalidate any previous editable text handler state.
On 2016/10/21 20:13:05, dmazzoni wrote:
> Could you comment that this is because we get selection
> events on menus, but the menu doesn't have focus?
> 
> I'd like to eventually fix this so that from the
> perspective of accessibility, menu items really do
> get focus.

Done.

[David Tseng, 2016-10-24 16:35:36]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-10-24 16:35:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2442583002/#ps20001
(title: "Invalidate the text edit handler on selection events")

[commit-bot: I haz the power, 2016-10-24 16:35:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 18:50:19]

Description was changed from

==========
Invalidate the text edit handler on selection events

This is necessary to make braille output work in menus. If a text edit handler
is active, output gets delegated through that handler, skipping the output o f
the current range.

BUG=657036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Invalidate the text edit handler on selection events

This is necessary to make braille output work in menus. If a text edit handler
is active, output gets delegated through that handler, skipping the output o f
the current range.

BUG=657036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-24 18:50:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-24 18:54:21]

Description was changed from

==========
Invalidate the text edit handler on selection events

This is necessary to make braille output work in menus. If a text edit handler
is active, output gets delegated through that handler, skipping the output o f
the current range.

BUG=657036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Invalidate the text edit handler on selection events

This is necessary to make braille output work in menus. If a text edit handler
is active, output gets delegated through that handler, skipping the output o f
the current range.

BUG=657036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4b5321f2888313442c6caf986a389a143920244c
Cr-Commit-Position: refs/heads/master@{#427107}
==========

[commit-bot: I haz the power, 2016-10-24 18:54:22]

Patchset 2 (id:??) landed as
https://crrev.com/4b5321f2888313442c6caf986a389a143920244c
Cr-Commit-Position: refs/heads/master@{#427107}