Source/platform/fonts/GlyphPageTreeNode.cpp - Issue 244253003: SimpleFontData::fillGlyphPage should not set zero for missing glyphs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/GlyphPageTreeNode.cpp

Issue 244253003: SimpleFontData::fillGlyphPage should not set zero for missing glyphs (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix expectation Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/GlyphPageTreeNode.cpp

diff --git a/Source/platform/fonts/GlyphPageTreeNode.cpp b/Source/platform/fonts/GlyphPageTreeNode.cpp

index 8cab69833f934eff37e1a8b27303bcc50550a7c6..1fb43ad5c4ebf781244550f33d487d374ca333bf 100644

--- a/Source/platform/fonts/GlyphPageTreeNode.cpp

+++ b/Source/platform/fonts/GlyphPageTreeNode.cpp

@@ -277,8 +277,7 @@ void GlyphPageTreeNode::initializePage(const FontData* fontData, unsigned pageNu

else if (fallbackPage->glyphAt(i)) {

m_page->setGlyphDataForIndex(i, fallbackPage->glyphDataForIndex(i));

newGlyphs = true;

- } else

- m_page->setGlyphDataForIndex(i, 0, 0);

+ }

}

if (!newGlyphs)