Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 244253003: SimpleFontData::fillGlyphPage should not set zero for missing glyphs (Closed)

Created:
6 years, 8 months ago by Kunihiko Sakamoto
Modified:
6 years, 8 months ago
Reviewers:
eae
CC:
blink-reviews, jamesr, krit, dsinclair, fs, jbroman, danakj, ed+blinkwatch_opera.com, Rik, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis, dglazkov
Visibility:
Public.

Description

SimpleFontData::fillGlyphPage should not set zero for missing glyphs From r171835, we call fillGlyphPage() multiple times on a glyph page when initializing a page for SegmentedFontData. It introduced a bug where glyph fallback for overlapping unicode ranges does not work correctly, because fillGlyphPage() may overwrite zero for missing glyphs. Since GlyphPage's constructor does zero-clear, there is no need to set zero for missing glyphs. BUG=none TEST=fast/css/font-face-unicode-range.html,svg/custom/svg-fonts-segmented.xhtml Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172107

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -23 lines) Patch
M LayoutTests/fast/css/font-face-unicode-range.html View 2 chunks +19 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/font-face-unicode-range-expected.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/svg/custom/svg-fonts-segmented.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontData.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/platform/fonts/GlyphPageTreeNode.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/fonts/mac/SimpleFontDataCoreText.cpp View 3 chunks +2 lines, -10 lines 0 comments Download
M Source/platform/fonts/skia/SimpleFontDataSkia.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Kunihiko Sakamoto
6 years, 8 months ago (2014-04-21 06:17:03 UTC) #1
eae
https://codereview.chromium.org/244253003/diff/1/LayoutTests/fast/css/font-face-unicode-range-expected.html File LayoutTests/fast/css/font-face-unicode-range-expected.html (right): https://codereview.chromium.org/244253003/diff/1/LayoutTests/fast/css/font-face-unicode-range-expected.html#newcode60 LayoutTests/fast/css/font-face-unicode-range-expected.html:60: <span class="courier">'''<span class="courier"> Did you mean to do <span ...
6 years, 8 months ago (2014-04-21 16:14:10 UTC) #2
Kunihiko Sakamoto
https://codereview.chromium.org/244253003/diff/1/LayoutTests/fast/css/font-face-unicode-range-expected.html File LayoutTests/fast/css/font-face-unicode-range-expected.html (right): https://codereview.chromium.org/244253003/diff/1/LayoutTests/fast/css/font-face-unicode-range-expected.html#newcode60 LayoutTests/fast/css/font-face-unicode-range-expected.html:60: <span class="courier">'''<span class="courier"> On 2014/04/21 16:14:10, eae wrote: > ...
6 years, 8 months ago (2014-04-22 01:01:59 UTC) #3
eae
LGTM Thanks!
6 years, 8 months ago (2014-04-22 01:04:32 UTC) #4
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-04-22 01:04:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/244253003/20001
6 years, 8 months ago (2014-04-22 01:04:43 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 02:10:31 UTC) #7
Message was sent while issue was closed. 
Change committed as 172107

Powered by Google App Engine
This is Rietveld 408576698