Avoid useless initialization in ScrollAnimatorNone::PerAxisData::animateScroll()

Avoid useless initialization in ScrollAnimatorNone::PerAxisData::animateScroll()

Avoid useless initialization in ScrollAnimatorNone::PerAxisData::animateScroll().
The value initially assigned to newPosition was always overwritten. Therefore,
the initial assignment can be omitted. This CL moves the initialization code to a
new inline function and initializes directly the newPosition variable with the
result of this new function.

The clang static code analizer was reporting this as a dead initialization.

R=abarth@chromium.org, eseidel@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172001

[abarth-chromium, 2014-04-20 14:10:05]

https://codereview.chromium.org/244253002/diff/1/Source/platform/scroll/Scrol...
File Source/platform/scroll/ScrollAnimatorNone.cpp (right):

https://codereview.chromium.org/244253002/diff/1/Source/platform/scroll/Scrol...
Source/platform/scroll/ScrollAnimatorNone.cpp:343: double newPosition;
Can we initialize it to zero?  We generally like to initialize scalars.

[Inactive, 2014-04-20 15:00:55]

https://codereview.chromium.org/244253002/diff/1/Source/platform/scroll/Scrol...
File Source/platform/scroll/ScrollAnimatorNone.cpp (right):

https://codereview.chromium.org/244253002/diff/1/Source/platform/scroll/Scrol...
Source/platform/scroll/ScrollAnimatorNone.cpp:343: double newPosition;
On 2014/04/20 14:10:05, abarth wrote:
> Can we initialize it to zero?  We generally like to initialize scalars.

Counter proposal: I moved the initialization to a new inline function and
newPosition is now initialized with the the result of this new function. This
way we avoid the useless assignment, *and* the scalar is initialized. PTAL.

[abarth-chromium, 2014-04-20 16:41:11]

lgtm

Perfect.  LGTM

[commit-bot: I haz the power, 2014-04-20 16:41:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/244253002/20001

[commit-bot: I haz the power, 2014-04-20 16:49:56]

Change committed as 172001