Fix editable text selection

chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Classes related to cursors that point to and select parts of
  * the automation tree.
  */
 
 goog.provide('cursors.Cursor');
@@ skipping 148 matching lines @@
   /**
    * A node appropriate for making selections.
    * @return {AutomationNode}
    * @private
    */
   get selectionNode_() {
     var adjustedNode = this.node;
     if (!adjustedNode)
       return null;
 
+    // Make no adjustments if we're within editable content.
+    if (adjustedNode.state.editable)
+      return adjustedNode;
+
     // Selections over line break nodes are broken.
     var parent = adjustedNode.parent;
     var grandparent = parent && parent.parent;
     if (parent.role == RoleType.lineBreak) {
       adjustedNode = grandparent;
     } else if (grandparent.role == RoleType.lineBreak) {
       adjustedNode = grandparent.parent;
     } else if (this.index_ == cursors.NODE_INDEX ||
         adjustedNode.role == RoleType.inlineTextBox ||
         chrome.automation.NameFromType[adjustedNode.nameFrom] != 'contents') {
@@ skipping 11 matching lines @@
   /**
    * An index appropriate for making selections.  If this cursor has a
    * cursors.NODE_INDEX index, the selection index is a node offset e.g. the
    * index in parent. If not, the index is a character offset.
    * @return {number}
    * @private
    */
   get selectionIndex_() {
     var adjustedIndex = this.index_;
 
-    // Selecting things under a line break is currently broken.
-    if (this.node.role == RoleType.inlineTextBox &&
+    if (!this.node)
+      return -1;
+
+    if (this.node.state.editable) {
+      return this.index_ == cursors.NODE_INDEX ? 0 : this.index_;
+    } else if (this.node.role == RoleType.inlineTextBox &&
+    // Selections under a line break are broken.
         this.node.parent && this.node.parent.role != RoleType.lineBreak) {
       if (adjustedIndex == cursors.NODE_INDEX)
         adjustedIndex = 0;
 
       var sibling = this.node.previousSibling;
       while (sibling) {
         adjustedIndex += sibling.name.length;
         sibling = sibling.previousSibling;
       }
     } else if (this.index_ == cursors.NODE_INDEX ||
@@ skipping 458 matching lines @@
   /**
    * Returns whether this range has valid start and end cursors.
    * @return {boolean}
    */
   isValid: function() {
     return this.start.isValid() && this.end.isValid();
   }
 };
 
 });  // goog.scope