Fix editable text selection

Fix editable text selection

We need to special-case setting selections when the focused node is itself editable.
- make no adjustments for the selected node; placing selection outside of the editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0 (placing selection at the beginning of the node); otherwise, use the character offset

TEST=move to a text field or content editable via ChromeVox commands; verify typing works to echo the keys. Furthermore, verify that in a content editable with headings, links, etc, jump commands move the selection. Finally, verify ChromeVox text movement commands (e.g. next character), moves selection in single line editables.
BUG=656349, 658045
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2ff29563c5b0619e3722c74af2fe3afa18819999
Cr-Commit-Position: refs/heads/master@{#427106}

[David Tseng, 2016-10-21 21:57:25]

Description was changed from

==========
Fix editable text selection

We need to special-case setting selections when the focused node is itself
editable.
- make no adjustments for the selected node; placing selection outside of the
editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0
(placing selection at the beginning of the node); otherwise, use the character
offset

BUG=
==========

to

==========
Fix editable text selection

We need to special-case setting selections when the focused node is itself
editable.
- make no adjustments for the selected node; placing selection outside of the
editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0
(placing selection at the beginning of the node); otherwise, use the character
offset

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-21 21:59:01]

Description was changed from

==========
Fix editable text selection

We need to special-case setting selections when the focused node is itself
editable.
- make no adjustments for the selected node; placing selection outside of the
editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0
(placing selection at the beginning of the node); otherwise, use the character
offset

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix editable text selection

We need to special-case setting selections when the focused node is itself
editable.
- make no adjustments for the selected node; placing selection outside of the
editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0
(placing selection at the beginning of the node); otherwise, use the character
offset

TEST=move to a text field or content editable via ChromeVox commands; verify
typing works to echo the keys. Furthermore, verify that in a content editable
with headings, links, etc, jump commands move the selection. Finally, verify
ChromeVox text movement commands (e.g. next character), moves selection in
single line editables.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-21 21:59:02]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-10-24 14:59:52]

lgtm

Don't forget to associate this with the bug number

[David Tseng, 2016-10-24 16:25:20]

Description was changed from

==========
Fix editable text selection

We need to special-case setting selections when the focused node is itself
editable.
- make no adjustments for the selected node; placing selection outside of the
editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0
(placing selection at the beginning of the node); otherwise, use the character
offset

TEST=move to a text field or content editable via ChromeVox commands; verify
typing works to echo the keys. Furthermore, verify that in a content editable
with headings, links, etc, jump commands move the selection. Finally, verify
ChromeVox text movement commands (e.g. next character), moves selection in
single line editables.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix editable text selection

We need to special-case setting selections when the focused node is itself
editable.
- make no adjustments for the selected node; placing selection outside of the
editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0
(placing selection at the beginning of the node); otherwise, use the character
offset

TEST=move to a text field or content editable via ChromeVox commands; verify
typing works to echo the keys. Furthermore, verify that in a content editable
with headings, links, etc, jump commands move the selection. Finally, verify
ChromeVox text movement commands (e.g. next character), moves selection in
single line editables.
BUG=656349,658045
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-24 16:25:23]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-10-24 16:25:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 18:49:19]

Description was changed from

==========
Fix editable text selection

We need to special-case setting selections when the focused node is itself
editable.
- make no adjustments for the selected node; placing selection outside of the
editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0
(placing selection at the beginning of the node); otherwise, use the character
offset

TEST=move to a text field or content editable via ChromeVox commands; verify
typing works to echo the keys. Furthermore, verify that in a content editable
with headings, links, etc, jump commands move the selection. Finally, verify
ChromeVox text movement commands (e.g. next character), moves selection in
single line editables.
BUG=656349,658045
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix editable text selection

We need to special-case setting selections when the focused node is itself
editable.
- make no adjustments for the selected node; placing selection outside of the
editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0
(placing selection at the beginning of the node); otherwise, use the character
offset

TEST=move to a text field or content editable via ChromeVox commands; verify
typing works to echo the keys. Furthermore, verify that in a content editable
with headings, links, etc, jump commands move the selection. Finally, verify
ChromeVox text movement commands (e.g. next character), moves selection in
single line editables.
BUG=656349,658045
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-24 18:49:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-24 18:54:16]

Description was changed from

==========
Fix editable text selection

We need to special-case setting selections when the focused node is itself
editable.
- make no adjustments for the selected node; placing selection outside of the
editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0
(placing selection at the beginning of the node); otherwise, use the character
offset

TEST=move to a text field or content editable via ChromeVox commands; verify
typing works to echo the keys. Furthermore, verify that in a content editable
with headings, links, etc, jump commands move the selection. Finally, verify
ChromeVox text movement commands (e.g. next character), moves selection in
single line editables.
BUG=656349,658045
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix editable text selection

We need to special-case setting selections when the focused node is itself
editable.
- make no adjustments for the selected node; placing selection outside of the
editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0
(placing selection at the beginning of the node); otherwise, use the character
offset

TEST=move to a text field or content editable via ChromeVox commands; verify
typing works to echo the keys. Furthermore, verify that in a content editable
with headings, links, etc, jump commands move the selection. Finally, verify
ChromeVox text movement commands (e.g. next character), moves selection in
single line editables.
BUG=656349,658045
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2ff29563c5b0619e3722c74af2fe3afa18819999
Cr-Commit-Position: refs/heads/master@{#427106}
==========

[commit-bot: I haz the power, 2016-10-24 18:54:16]

Patchset 1 (id:??) landed as
https://crrev.com/2ff29563c5b0619e3722c74af2fe3afa18819999
Cr-Commit-Position: refs/heads/master@{#427106}